Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change prepublishOnly to prepack #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarondill
Copy link

This change allows installation of the package from git urls (ie npm i uetchy/create-create-app), as well as downloading the source and running npm pack to generate a tarball of the package.

@aarondill
Copy link
Author

There is currently a bug in the npm CLI which does not call prepack on installation of git dependencies (npm/cli#1865 and npm/pacote#257), so this change will not work with git installations until that is fixed, however it still allows for npm pack as well as future usage of installation directly from github.
The alternative solution to allow github installations to function is to use a prepare script, but this script runs on npm install without arguments, so it will compile files when installing dependencies for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant