This repository has been archived by the owner on Jan 22, 2019. It is now read-only.
Fix issues with chunk hashes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ExtractTextWebpackPlugin and ExtractCSSWebpackChunks because of an issue with css style ordering, which resulted in a new hash being generated for every css chunk. See: webpack-contrib/extract-text-webpack-plugin#548 and faceyspacey/extract-css-chunks-webpack-plugin#41
Also adds some plugins to better handle chunk hashes when stuff changes.
The only remaining issue is that bootstrap-[contenthash].js changes whenever some other file changes even though nothing changes in the bootstrap file. We have the manifest array normally in the bootstrap file (emitted js files) inline in the html. There’s a plugin that extracts it from the bootstrap file and removes it. But the hash is generated before this happens.
We could remove the hash from the bootstrap file but if the webpack bootstrap code changes we could run into caching problems. But this should only happen if we update webpack and it has changed the bootstrap code.