fix(core): onDrop and onPaste only registered when defined #5681 #5684
Conversation
|
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| this.on('drop', ({ event, slice, moved }) => this.options.onDrop(event, slice, moved)) | ||
| this.on('paste', ({ event, slice }) => this.options.onPaste(event, slice)) |
There was a problem hiding this comment.
I figured, that while I was here, I may as well promote these to be actual editor events that follow the same pattern as others. This allows flexibility to register multiple handlers to listen to the same event
There was a problem hiding this comment.
@nperez0111 This resolves this, right?
There was a problem hiding this comment.
@svenadlung it does 😉
Changes Overview
This updates the
onDropandonPasteevent callbacks to only ever be registered if they exist on the editor instance at creation.It also refactors them to be extensions rather than separate Prosemirror plugins which would causes plugins to be destroyed and recreated immediately
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues