Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: type definitions are only emitted for a single package's code #5665

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

nperez0111
Copy link
Contributor

@nperez0111 nperez0111 commented Sep 26, 2024

Changes Overview

This changes how the tiptap packages are bundled to enforce that the type definitions that are emitted into the bundle are only for this packages code rather than including type definitons of dependent tiptap packages.

Implementation Approach

Before:
image

After:
image

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Discussion reporting the issue: #5660 (reply in thread)

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 0c89066

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 55 packages
Name Type
@tiptap/extension-collaboration-cursor Minor
@tiptap/extension-code-block-lowlight Minor
@tiptap/extension-character-count Minor
@tiptap/extension-horizontal-rule Minor
@tiptap/extension-collaboration Minor
@tiptap/extension-floating-menu Minor
@tiptap/extension-ordered-list Minor
@tiptap/extension-table-header Minor
@tiptap/extension-bubble-menu Minor
@tiptap/extension-bullet-list Minor
@tiptap/extension-font-family Minor
@tiptap/extension-list-keymap Minor
@tiptap/extension-placeholder Minor
@tiptap/extension-superscript Minor
@tiptap/extension-blockquote Minor
@tiptap/extension-code-block Minor
@tiptap/extension-dropcursor Minor
@tiptap/extension-hard-break Minor
@tiptap/extension-table-cell Minor
@tiptap/extension-text-align Minor
@tiptap/extension-text-style Minor
@tiptap/extension-typography Minor
@tiptap/extension-gapcursor Minor
@tiptap/extension-highlight Minor
@tiptap/extension-list-item Minor
@tiptap/extension-paragraph Minor
@tiptap/extension-subscript Minor
@tiptap/extension-table-row Minor
@tiptap/extension-task-item Minor
@tiptap/extension-task-list Minor
@tiptap/extension-underline Minor
@tiptap/extension-document Minor
@tiptap/extension-heading Minor
@tiptap/extension-history Minor
@tiptap/extension-mention Minor
@tiptap/extension-youtube Minor
@tiptap/extension-italic Minor
@tiptap/extension-strike Minor
@tiptap/extension-color Minor
@tiptap/extension-focus Minor
@tiptap/extension-image Minor
@tiptap/extension-table Minor
@tiptap/extension-bold Minor
@tiptap/extension-code Minor
@tiptap/extension-link Minor
@tiptap/extension-text Minor
@tiptap/starter-kit Minor
@tiptap/suggestion Minor
@tiptap/react Minor
@tiptap/vue-2 Minor
@tiptap/vue-3 Minor
@tiptap/core Minor
@tiptap/html Minor
@tiptap/pm Minor
tiptap-demos Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 0c89066
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/66f5549a7b43d80008667832
😎 Deploy Preview https://deploy-preview-5665--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 merged commit 6834a7f into develop Sep 26, 2024
14 checks passed
@nperez0111 nperez0111 deleted the output-ts-types branch September 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant