Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in a collab setting, disable transactions that are trying to sync invalid content #5207

Merged
merged 14 commits into from
Oct 21, 2024

Conversation

nperez0111
Copy link
Contributor

Changes Overview

This enables content checking for changes made by the collaboration plugin.
The changes made by the collaboration plugin are outside of the usual flow of content provided on initialization.
So, we need to handle it separately by filtering out the transactions where it occurs

Implementation Approach

Testing Done

Verification Steps

Additional Notes

Checklist

  • I have renamed my PR according to the naming conventions. (e.g. feat: Implement new feature or chore(deps): Update dependencies)
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ac932b9
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/67166fe1abfd41000875ea2b
😎 Deploy Preview https://deploy-preview-5207--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 force-pushed the develop branch 2 times, most recently from bcaef5c to 7e7ae19 Compare June 12, 2024 04:33
@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch from 21d8d1d to 42dee59 Compare June 13, 2024 21:13
@bdbch bdbch deleted the branch develop June 26, 2024 21:57
@bdbch bdbch closed this Jun 26, 2024
@nperez0111 nperez0111 reopened this Jun 27, 2024
@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch from 7138eac to 960bbe4 Compare July 2, 2024 20:02
Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: ac932b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/extension-collaboration Minor
@tiptap/core Minor
@tiptap/extension-blockquote Minor
@tiptap/extension-bold Minor
@tiptap/extension-bubble-menu Minor
@tiptap/extension-bullet-list Minor
@tiptap/extension-character-count Minor
@tiptap/extension-code-block-lowlight Minor
@tiptap/extension-code-block Minor
@tiptap/extension-code Minor
@tiptap/extension-collaboration-cursor Minor
@tiptap/extension-color Minor
@tiptap/extension-document Minor
@tiptap/extension-dropcursor Minor
@tiptap/extension-floating-menu Minor
@tiptap/extension-focus Minor
@tiptap/extension-font-family Minor
@tiptap/extension-gapcursor Minor
@tiptap/extension-hard-break Minor
@tiptap/extension-heading Minor
@tiptap/extension-highlight Minor
@tiptap/extension-history Minor
@tiptap/extension-horizontal-rule Minor
@tiptap/extension-image Minor
@tiptap/extension-italic Minor
@tiptap/extension-link Minor
@tiptap/extension-list-item Minor
@tiptap/extension-list-keymap Minor
@tiptap/extension-mention Minor
@tiptap/extension-ordered-list Minor
@tiptap/extension-paragraph Minor
@tiptap/extension-placeholder Minor
@tiptap/extension-strike Minor
@tiptap/extension-subscript Minor
@tiptap/extension-superscript Minor
@tiptap/extension-table-cell Minor
@tiptap/extension-table-header Minor
@tiptap/extension-table-row Minor
@tiptap/extension-table Minor
@tiptap/extension-task-item Minor
@tiptap/extension-task-list Minor
@tiptap/extension-text-align Minor
@tiptap/extension-text-style Minor
@tiptap/extension-text Minor
@tiptap/extension-typography Minor
@tiptap/extension-underline Minor
@tiptap/extension-youtube Minor
@tiptap/html Minor
@tiptap/pm Minor
@tiptap/react Minor
@tiptap/starter-kit Minor
@tiptap/suggestion Minor
@tiptap/vue-2 Minor
@tiptap/vue-3 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch 2 times, most recently from fcedfe5 to d3d2b5c Compare July 24, 2024 15:28
@nperez0111
Copy link
Contributor Author

This isn't working, because when disabling the extension, it still seems to be bound to the y doc state (since it is synchronized outside the editor). I think I may have to destroy the editor instead of getting the plugin to be unregistered (since it is still holding onto references in the current editor).

Will need to think more on this later.

@nperez0111 nperez0111 force-pushed the feature/disable-invalid-collab branch from 820e64a to 81b471d Compare October 21, 2024 07:29
@nperez0111 nperez0111 merged commit 873a67c into develop Oct 21, 2024
12 of 13 checks passed
@nperez0111 nperez0111 deleted the feature/disable-invalid-collab branch October 21, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants