-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in a collab setting, disable transactions that are trying to sync invalid content #5207
Conversation
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bcaef5c
to
7e7ae19
Compare
21d8d1d
to
42dee59
Compare
7138eac
to
960bbe4
Compare
🦋 Changeset detectedLatest commit: ac932b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fcedfe5
to
d3d2b5c
Compare
This isn't working, because when disabling the extension, it still seems to be bound to the y doc state (since it is synchronized outside the editor). I think I may have to destroy the editor instead of getting the plugin to be unregistered (since it is still holding onto references in the current editor). Will need to think more on this later. |
…nc invalid content
820e64a
to
81b471d
Compare
Changes Overview
This enables content checking for changes made by the collaboration plugin.
The changes made by the collaboration plugin are outside of the usual flow of content provided on initialization.
So, we need to handle it separately by filtering out the transactions where it occurs
Implementation Approach
Testing Done
Verification Steps
Additional Notes
Checklist
feat: Implement new feature
orchore(deps): Update dependencies
)Related Issues