Extend nodePasteRule find type to most generic PasteRuleFinder
#3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
approved these changes
Feb 18, 2023
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team!
First off, thank you for building and maintaining
tiptap, it is truly a pleasure to work with.While working on our editor, we ran across
nodePasteRulewhich we wanted to use with a non-regexp pattern.The specs in
PasteRule.tsdoe also allow functions as argument forfind, and functions actually work perfectly withnodePasteRuleas well, but there will be a type error.This PR changes the type of
nodePasteRule'sfindto the most general type it can accept.I hope it's OK to open a PR directly for this two-line change.