Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: custom text serializers should override text serializers defined in the schema #3546

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix: custom text serializers should override text serializers defined in the schema #3546

merged 1 commit into from
Dec 16, 2022

Conversation

tovaschreier
Copy link
Contributor

Fixes #3538

@netlify
Copy link

netlify bot commented Dec 14, 2022 •
edited
Loading

✅ Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 1b5dd5d
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/639a3cabda530a0008ae9230
😎 Deploy Preview https://deploy-preview-3546--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch
Copy link
Contributor

bdbch commented Dec 16, 2022

Looks good to me! Thank you!

@bdbch bdbch merged commit f3f3675 into ueberdosis:main Dec 16, 2022
@tovaschreier tovaschreier deleted the fix-text-serializer-override branch December 16, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdbch bdbch bdbch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textSerializers in generateText don't override renderText set in schema
2 participants
@tovaschreier @bdbch