fix: set default allowedPrefixes null #3239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
vinicius73
pushed a commit
to nextcloud/text
that referenced
this pull request
Sep 30, 2022
Ref.: ueberdosis/tiptap#3239 Signed-off-by: Vinicius Reis <[email protected]>
mejo-
pushed a commit
to nextcloud/text
that referenced
this pull request
Oct 12, 2022
Ref.: ueberdosis/tiptap#3239 Signed-off-by: Vinicius Reis <[email protected]>
juliushaertl
pushed a commit
to nextcloud/text
that referenced
this pull request
Oct 13, 2022
Ref.: ueberdosis/tiptap#3239 Signed-off-by: Vinicius Reis <[email protected]>
vinicius73
pushed a commit
to nextcloud/text
that referenced
this pull request
Oct 13, 2022
Ref.: ueberdosis/tiptap#3239 Signed-off-by: Vinicius Reis <[email protected]>
akrolsmir
added a commit
to manifoldmarkets/manifold
that referenced
this pull request
Oct 14, 2022
|
Hrm, given the number of breakages, I'd say this was bad change -- imo default behavior should be At the very least, y'all should update https://tiptap.dev/api/utilities/suggestion to mention the new default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #3238