fix: move React flushSync to microtask
#3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid seeing the `Warning: flushSync was called from inside a lifecycle method. React cannot flush when React is already rendering. Consider moving this call to a scheduler task or micro task.` error, we need to move the `flushSync()` code that avoids automatic batching to a microtask to not fire a lifecycle event `setState()` during rendering. Fixes warning introduced in ueberdosis#2985
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bdbch
approved these changes
Sep 13, 2022
|
@bdbch @sampi - FYI We just tested this change in our Tiptap React 18 application and noticed it has the same cursor position bug that this For us, reproducing is as easy as:
Expected: Cursor moves to next line (new empty paragraph) |
|
Thanks for reporting. I'll try reproduce this too. |
|
FWIW We are on We had upgraded to this version because in the past, Tiptap allowed minor version upgrades. Was there a specific reason that |
|
We had a few issues with minor changes breaking the editor beforce which is why we fixed it. |
@bdbch I can confirm that with all the latest versions of Tiptap packages that this is still an issue. |
|
Also experiencing this issue on latest beta
|
kylealwyn
added a commit
to kylealwyn/tiptap
that referenced
this pull request
Dec 13, 2022
Do the same thing as ueberdosis#3188
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
Do the same thing as ueberdosis#3188
X-oss-byte
added a commit
to X-oss-byte/Tiptap.dev
that referenced
this pull request
Oct 8, 2023
* v2.0.0-beta.205 * fix(extension-bubble-menu): don't debounce without valid selection (#3501) * refactor(extension-youtube): rename utility function name (#3498) * Check if url exists (#3484) * Update menus.md (#3457) * docs(docs): add new installation notes for peerDependencies * build(deps): bump minimatch from 3.0.4 to 3.1.2 in /demos (#3489) Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2. - [Release notes](https://github.com/isaacs/minimatch/releases) - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.0.4...v3.1.2) --- updated-dependencies: - dependency-name: minimatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: change release from tag to release * 2.0.0-beta.206 * docs(docs): update formatting on installation guide * docs: add note about starter-kit dependencies * docs: remove unnecessary text in docs * docs: add installation notes to extensions * fix(extension-table): add prosemirror-tables to peerDependencies * v2.0.0-beta.207 * docs: rotate rooms * docs: inject collaboration rooms in build process * Custom text serializers should override text serializers defined in the schema (#3546) * 2.0.0-beta.208 * v2.0.0-beta.209 * update sandboxes * docs: add job IllumIDesk * docs: fix typo in job description * docs: refactor installation docs * docs: explain peer dependencies * docs: fix text * docs: improve texts * docs: improve peer dependency hints * docs: remove sponsor box * docs: about & collab * docs: update hocuspocus hints * Update sink-list-item.md (#3629) correct text copy * 🧹 Allow `editor.setEditable` to omit updates (#3301) * 🧹 Allow `editor.setEditable` to omit updates * 📚 Document change to `editor.setEditable` * docs: remove early access hint * Change Build Process to Lerna + tsup & prepare for prosemirror-meta package (#3555) * chore:(core): migrate to tsup * chore: migrate blockquote and bold to tsup * chore: migrated bubble-menu and bullet-list to tsup * chore: migrated more packages to tsup * chore: migrate code and character extensions to tsup * chore: update package.json to simplify build for all packages * chore: move all packages to tsup as a build process * chore: change ci build task * chore: clean up and fix issues related to new build * fix: fix demo build * fix: fix demo build * fix: fix tsconfig files to reference only one source * fix: fix minor ts issues * chore: add prettier * fix(typo): typescript.md (#3657) Add a forgotten quotation mark in the import and specify the language in md code block * Update schema.md (#3645) The schema definition exmaple uses the node name `document` while the explaining text says that the node name is `doc`. * chore: set eslint as default formatter * feat(pm): new prosemirror package for dependency resolving * chore:(core): migrate to tsup * chore: migrate blockquote and bold to tsup * chore: migrated bubble-menu and bullet-list to tsup * chore: migrated more packages to tsup * chore: migrate code and character extensions to tsup * chore: update package.json to simplify build for all packages * chore: move all packages to tsup as a build process * chore: change ci build task * feat(pm): add prosemirror meta package * rfix: resolve issues with build paths & export mappings * docs: update documentation to include notes for @tiptap/pm * chore(pm): update tsconfig * chore(packages): update packages * fix(pm): add package export infos & fix dependencies * chore(general): start moving to pm package as deps * chore: move to tiptap pm package internally * fix(demos): fix demos working with new pm package * fix(tables): fix tables package * fix(tables): fix tables package * chore(demos): pinned typescript version * chore: remove unnecessary tsconfig * chore: fix netlify build * fix(demos): fix package resolving for pm packages * fix(tests): fix package resolving for pm packages * fix(tests): fix package resolving for pm packages * chore(tests): fix tests not running correctly after pm package * chore(pm): add files to files array * chore: update build workflow * chore(tests): increase timeout time back to 12s * chore(docs): update docs * chore(docs): update installation guides & pm information to docs * chore(docs): add link to prosemirror docs * fix(vue-3): add missing build step * chore(docs): comment out cdn link * chore(docs): remove semicolons from docs * chore(docs): remove unnecessary installation note * chore(docs): remove unnecessary installation note * v2.0.0-beta.210 * update publish task * update publish task * update publish task * update publish task * remove peer deps link * fix(bubble-menu): fix bubble menu imports * v2.0.0-beta.211 * fix(collaboration): fix missing y-prosemirror dependency * fix(core): fix broken types in definition file * v2.0.0-beta.212 * fix(bubble-menu): change lodash to lodash-es for esbuild * v2.0.0-beta.213 * Added CSS Required for Setup (#3711) * Added CSS Setup Context It was previously not clear that additional CSS was required to display placeholders. * Fixed Typo. * Update installation guides (#3698) * docs: update installation guides * docs: remove base setup * docs: complete the prosemirror package documentation * Make y-prosemirror a peer dependency (extension-collaboration) (#3697) * refactor(extension-collaboration): make y-prosemirror a peer dep * docs: update installation of extension-collaboration --------- Co-authored-by: Dominik <[email protected]> * refactor(extension-bubble-menu): remove lodash types, replace pm deps with tiptap/pm (#3696) * Remove lodash dependencies in extension-floating-menu (#3695) * refactor(extension-floating-menu): remove lodash dependencies * fix: typo --------- Co-authored-by: Dominik <[email protected]> * build(deps): bump cypress-io/github-action from 4.2.0 to 5.0.8 (#3707) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 4.2.0 to 5.0.8. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v4.2.0...v5.0.8) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (#3687) Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/kornelski/http-cache-semantics/releases) - [Commits](https://github.com/kornelski/http-cache-semantics/commits) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(bubble-menu): move from lodash-es back to lodash, use named import * Move back from tsup/esbuild to rollup (#3720) * fix: bring back global rollup config * fix: add rollup build for packages except pm * fix: rollup global build * fix: fix memory leak on build * fix(character-count): revert files * fix: builds run individual per rollup and lerna * chore: remove old rollup * fix(blockquote): correct the main module path * fix(character count): bump version number * v2.0.0-beta.214 * fix: fix builds including prosemirror * v2.0.0-beta.215 * fix(bubble-menu): fix lodash import * integrate typesense * v2.0.0-beta.216 * integrate typesense * integrate typesense * schedule typesearch scraper * schedule typesearch scraper * fix(bubble-menu): exclude lodash/debounce from externals * v2.0.0-beta.217 * fix: Prevent drag event from being ignored (#3677) * build(deps): bump actions/cache from 3.0.11 to 3.2.5 (#3741) Bumps [actions/cache](https://github.com/actions/cache) from 3.0.11 to 3.2.5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.0.11...v3.2.5) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump act10ns/slack from 1 to 2 (#3404) Bumps [act10ns/slack](https://github.com/act10ns/slack) from 1 to 2. - [Release notes](https://github.com/act10ns/slack/releases) - [Changelog](https://github.com/act10ns/slack/blob/master/RELEASE.md) - [Commits](act10ns/slack@v1...v2) --- updated-dependencies: - dependency-name: act10ns/slack dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump json5 from 1.0.1 to 1.0.2 (#3605) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump json5 from 2.2.1 to 2.2.3 in /demos (#3607) Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v2.2.1...v2.2.3) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/checkout from 3.0.2 to 3.3.0 (#3609) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.0.2...v3.3.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/upload-artifact from 3.1.0 to 3.1.2 (#3610) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.0 to 3.1.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3.1.0...v3.1.2) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/setup-node from 3.5.1 to 3.6.0 (#3613) Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.5.1 to 3.6.0. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v3.5.1...v3.6.0) --- updated-dependencies: - dependency-name: actions/setup-node dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update regex to exclude channel URL unfurling (#3750) * Fix type for BubbleMenu prop pluginKey (#3678) * Extend `nodePasteRule` `find` type to most generic `PasteRuleFinder` (#3759) * fix(extension-link): Click handler opens selected link instead of clicked link (#3732) * fix(typography): dont create fractions in the middle of a string (#3762) * v2.0.0-beta.218 * Use Tailwind CDN direclty? (#3643) I realized that if I use Tailwind's CDN directly, you can have it react to dark mode directly. * Override schema text serializers if provided in getText options (#3672) * chore: add eslintcache (#3525) * document removing or overriding link attributes (#3576) The documentation mentions being able to override the `rel` on links but doesn't explain how. It also doesn't tell you how to remove the rel if needed(set to null). Add an example of removing a default attribute and overriding one to a different value. * Add onFirstRender callback option (#3600) * Added onFirstRender callback option This PR is a simple forwarding of a very useful callback from the ySyncPlugin. * Fix invalid function name * Add Plugin Key to placeholder component. (#3652) * Add Plugin Key to placeholder component. Key added to fix error duplicate plugin when using `Placeholder` component. * Add PluginKey import --------- Co-authored-by: Dominik <[email protected]> * Export `createNodeFromContent` and other missing helpers (#3558) * Queue flushSync microtask (#3533) Do the same thing as ueberdosis/tiptap#3188 * build(deps): bump cypress-io/github-action from 5.0.8 to 5.0.9 (#3766) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 5.0.8 to 5.0.9. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v5.0.8...v5.0.9) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat: #3540 Ability to preserve marks on lists (#3541) * feat: #3540 Ability to preserve marks on lists * feat: preserveAttrs in list items * `keepMarks` is working, but need help with `keepAttrs` * fix: conflict * avoid casting * fix: move y-prosemirror to peer-deps (#3763) Co-authored-by: Dominik <[email protected]> * fix: #3773 - Array for content breaks editor (#3786) * fix: #3773 - Array for content breaks editor * fix: lint warning * Update php.md (#3618) Changes are based on reading this thread ueberdosis/tiptap#1515 (comment) This example relies on AlpineJS still and doing causes the editor to be wrapped in an observable/reactive layer. Moving the editor out of the returned object means it doesn't become a proxy object; otherwise, `editor.commands.setContent(content, false)` will already trigger an error `Range Error: Applying a mismatched transaction` and not work. * add optionalSlashSlash to protocol options (#3675) * add optionalSlashSlash to protocol options * Update documentation * rename optionalSlashSlash to optionalSlashes * regenerate package-lock.json with node v16 * fix(core): allow insertContentAt and insertContent text node arrays (#3790) * fix(core): allow insertContentAt and insertContent to handle array of text nodes * fix(core): allow insertContent via json including a text content * chore: allow new ReactComponentContent components to be created (#3782) * chore: allow users to create new react nodeview editor content components * style: remove trailing spaces * fix(react): reset initialized when editorcontent is unmounting (#3781) * fix(react): reset initialized when editorcontent is unmounting * style: remove unneeded if statement * docs: add extension cli note to contributing docs (#3793) * docs: add extension cli note to contributing docs * docs: add notes to CLI * docs: fix rollup and vite naming * fix: update typings for node view decorations (#3783) * fix: update typings for node view decorations * fix(core): update types for NodeView * fix(core): declare props.decorations as decorationWithType * build(deps): bump actions/cache from 3.2.5 to 3.2.6 (#3795) Bumps [actions/cache](https://github.com/actions/cache) from 3.2.5 to 3.2.6. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.2.5...v3.2.6) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v2.0.0-beta.219 * fix(core): fix destroyed view causing errors on dispatchTransaction (#3799) * fix(tests): fix tests for lists * v2.0.0-beta.209 * Only allow left mouse button to open links (#3777) * Only allow left mouse button to open links * fix lint errors * core: only check doc.textBetween if other checks pass (#3778) * fix: package-lock * fix: use prose-base class for sm screens to prevent override of prose-invert (#3810) * fix(core): fix linting issues * Adds attributes to toggleList (#3776) * Adds attributes to toggleList When dealing with different variants of bullet lists, I wanted to adopt the same technique I used for different paragraph variants. Since `wrapInList` is capable of receiving attributes, just like `setNode` is, I don't see any reason why `toggleList` should not be capable of the same. Here's my bullet list extension in action that is in need of attributes support. ```js export const CustomBulletList = BulletList.extend({ content: 'listItem*', addAttributes() { return { variant: { default: DEFAULT_LIST, renderHTML: attributes => { return { class: `list-${attributes.variant}`, }; }, }, }; }, addCommands() { return { toggleBulletList: attributes => (c) => { return c.commands.toggleListCustom(this.name, this.options.itemTypeName, attributes); }, }; }, }); ``` * Update toggle-list.md * Update toggle-list.md * fix(tests): add assertion for each valid/invalid link (#3815) * fix(tests): add assertion for each valid/invalid link * chore(tests): disable video generation * feat(react): allow react renderer to assign attributes to react renderer element (#3812) * fix(react): allow updating event handlers on editor (#3811) * tests: increase timeout * Improve Cypress Test runner performance with parallelization (#3817) * test: only run integration tests * test: only run integration tests * test: try using test spec matrix * test: try using test spec matrix * test: try using test spec matrix * test: try using test spec matrix * test: try using test spec matrix * tests: update test branches * WIP - list backspace behaviour * WIP - add handling when backspace is pressed at start of a list item * WIP - fix undoInputRule * build(deps): bump cypress-io/github-action from 5.0.9 to 5.2.0 (#3835) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 5.0.9 to 5.2.0. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v5.0.9...v5.2.0) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * try to fix docs link order in menu * fix inconsistent tiptap spelling * docs: fix docs order and add new pro extensions * docs: update extension list * update docs * fix: Ordered list start support broke in #3541 (#3833) * fix: #3831 * fix: default attribute + predicate * docs: link to support page * refactor(extension-youtube): command types (#3842) * build(deps): bump actions/checkout from 3.3.0 to 3.4.0 (#3864) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.3.0...v3.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump cypress-io/github-action from 5.2.0 to 5.5.0 (#3863) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 5.2.0 to 5.5.0. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v5.2.0...v5.5.0) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump webpack from 5.73.0 to 5.76.0 (#3855) Bumps [webpack](https://github.com/webpack/webpack) from 5.73.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.73.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * temporary changes * docs: consistent naming (#3882) * feat(attributes): dynamic default (#3379) * style(core): fix linting issues (#3884) * Handle NodeViews in BubbleMenu positioning (#3881) * fix(bubble-menu): use correct children of node view renderers for clientRect * fix(bubble-menu): remove lodash * fix(bubble-menu): support vue node views * fix(demos): revert bubble menu demo * chore: add Dev demo folder (#3887) * ci: remove slack notifications (#3885) * docs: update nodes and extensions lists (#3886) * docs: remove pro extension callout from collab docs (#3883) * Fixing reoccurring issue #3331 and improving related PR #3533 (#3862) * Add custom paragraph example * Remove unnecessary queueMicrotask * Release Candidate Preparation (#3890) * 2.0.0-rc.0 * chore: make fixed version dependencies while on rc * 2.0.0-rc.1 * chore: add nnew release and prerelease actions (#3836) * TiptapCollab * Merge pull request #3895 from ueberdosis/feature/ttCollabProvider Updates @hocuspocus/provider, moves demo to TiptapCollab * fix(lists): improve list behaviour * chore: change back to independent releases * Collaboration: Fix history after late-registering plugins (#3901) * fix(extension-collaboration): fix history after late-registering plugins * fix(extension-collaboration): fix history after late-registering plugins * chore: remove independent * 2.0.0-rc.2 * chore: change peerDeps * chore: update package-lock.json * ci: remove slack notifications (#3898) * ci: remove slack notifications * clean up envs * build(deps): bump actions/checkout from 3.4.0 to 3.5.0 (#3889) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.4.0...v3.5.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump cypress-io/github-action from 5.5.0 to 5.5.1 (#3888) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 5.5.0 to 5.5.1. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v5.5.0...v5.5.1) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/cache from 3.2.6 to 3.3.1 (#3846) Bumps [actions/cache](https://github.com/actions/cache) from 3.2.6 to 3.3.1. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3.2.6...v3.3.1) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: prepare for stable release (#3892) * docs: changelogs * docs: about * New Issue & Discussion Templates (#3907) * chore: update github templates * chore: add discussion templates * chore: update issue templates * chore: add pull request template * chore: add pull request template * chore: add pull request template * feat(core): add editor to this context in schema functions (#3909) * update lerna version * v2.0.0-rc.3 * update packagelock * v2.0.0 * update package-lock * add new release script * add rc as pre tag * pin lerna version * update package-lock * update lerna * chore: remove core from pm dependencies * docs: fix nodes list * chore: dont push new versions automatically * package-lock update * Updates @hocuspocus/provider to 2.0.1 (#3913) * Updates @hocuspocus/provider to 2.0.1 (#3913) * fix: Update peerDependencies to fix lerna version tasks (#3914) * v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps * Update clickHandler.ts (#3917) Fix left click invalid * Update clickHandler.ts (#3917) Fix left click invalid * fix: Update peerDependencies to fix lerna version tasks (#3914) * v2.1.0-rc.0 * revert version to 2.0.0 * dev: temporarily disable commits for release * dev: set back lerna version * disable commits for releases by default * chore(core): add peerDeps * chore(extension-blockquote): add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: add peerDeps * chore: revert 2.1.0 test changes * chore: allow react 17 and upwards * chore: update package-lock.json * chore: move y-prosemirror to peerDeps * chore: move y-prosemirror to dev deps * chore: move y-prosemirror to dev deps * v2.0.1 * update demo styles * fix(list-item): improve delete behaviour * Update CHANGELOG.md * Update CHANGELOG.md * feat: landingpage demo (#3925) * feat: Tiptap collab demo styling * feat: add box-shadow to collab demo * fix(react): fix rebinding events not overwriting editor.on (#3935) * fix(react): fix rebinding events not overwriting editor.on * fix(react): move ref assignment inside if * v2.0.2 * build(deps): bump cypress-io/github-action from 5.5.1 to 5.6.1 (#3933) Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 5.5.1 to 5.6.1. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Commits](cypress-io/github-action@v5.5.1...v5.6.1) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: clear nodes when cursor at start of empty isolating parent (#3943) * fix: clear nodes when cursor at start of empty isolating parent * fix: dont break backspace behavior when childCount is over 1 * fix: check if parent is textblock * fix: add strict pos check for parent isolating pos * demo: add isolation clear demo * v2.1.0-pre.0 * fix(bubble-menu): fix debounce not working with collab/collaboration cursor (#3956) * v2.1.0-pre.1 * fix(bubble-menu): fix debounce not working with collab/collaboration cursor (#3956) * v2.0.3 * Retain existing config when calling configure() on Marks and Extensions (#3822) * fix(extension-link): fix link not being kept when pasting url with link (#3975) * fix(extension-link): fix llinks not being kept when pasted text includes url * fix(extension-link): fix links not being linked correctly on the correct pos * fix(link): fix pasting behavior and move all to one plugin * fix(link): dont do custom behavior if no links were pasted * fix(link): copied text link should be kept * fix(link): fix autolink overriding pasted links * fix(link): fix links not pasting the correct link on selected text * v2.1.0-rc.2 * fix(core): remove configure from extend functionality * v2.1.0-rc.3 * chore: remove unused tests * fix(link): fix links autolinking when not needed (#3989) * v2.1.0-rc.4 * Update LICENSE.md * fix: typo in commands.md * feat: add tiptap class * update docs * update demos * fix(extension-link): fix paste handling * do not dispatch transaction without any links getting pasted * prevent onPaste handling in code blocks * v2.1.0-rc.5 * fix package-lock * v2.1.0-rc.7 * v2.1.0-rc.8 * Update README.md * refactor(lists): start refactoring lists code --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Dominik Biedebach <[email protected]> Co-authored-by: Sven Adlung <[email protected]> Co-authored-by: Gustavo Rocha <[email protected]> Co-authored-by: Jaga Santagostino <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Martin Kriegeskorte <[email protected]> Co-authored-by: Tova Schreier <[email protected]> Co-authored-by: svenadlung <[email protected]> Co-authored-by: Au <[email protected]> Co-authored-by: Zaymon Antonio <[email protected]> Co-authored-by: Dominik <[email protected]> Co-authored-by: Dominik Biedebach <[email protected]> Co-authored-by: N0N1m3 <[email protected]> Co-authored-by: Mattias Reichel <[email protected]> Co-authored-by: James <[email protected]> Co-authored-by: Matthew Mullin <[email protected]> Co-authored-by: Justin Maier <[email protected]> Co-authored-by: Ray Bateman <[email protected]> Co-authored-by: Jie <[email protected]> Co-authored-by: James Taber <[email protected]> Co-authored-by: Rico <[email protected]> Co-authored-by: Harrison Lo <[email protected]> Co-authored-by: Simon He <[email protected]> Co-authored-by: Ed Pelc <[email protected]> Co-authored-by: Flamenco <[email protected]> Co-authored-by: Ta'zirah Marwan <[email protected]> Co-authored-by: Jack Sleight <[email protected]> Co-authored-by: Kyle Alwyn <[email protected]> Co-authored-by: Hari Haran <[email protected]> Co-authored-by: Peter Fox <[email protected]> Co-authored-by: taras-turchenko-moc <[email protected]> Co-authored-by: Abdullah Atta <[email protected]> Co-authored-by: Tim Raderschad <[email protected]> Co-authored-by: René Eschke <[email protected]> Co-authored-by: Myles J <[email protected]> Co-authored-by: Kento Moriwaki <[email protected]> Co-authored-by: Jan Thurau <[email protected]> Co-authored-by: jhsy <[email protected]> Co-authored-by: Nick Holden <[email protected]> Co-authored-by: Philip Isik <[email protected]> Co-authored-by: Marcus Lyons <[email protected]> Co-authored-by: Patrick Baber <[email protected]>
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
To avoid seeing the `Warning: flushSync was called from inside a lifecycle method. React cannot flush when React is already rendering. Consider moving this call to a scheduler task or micro task.` error, we need to move the `flushSync()` code that avoids automatic batching to a microtask to not fire a lifecycle event `setState()` during rendering. Fixes warning introduced in ueberdosis#2985
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
Do the same thing as ueberdosis#3188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid seeing the
Warning: flushSync was called from inside a lifecycle method. React cannot flush when React is already rendering. Consider moving this call to a scheduler task or micro task.error, we need to move theflushSync()code that avoids automatic batching to a microtask to not fire a lifecycle eventsetState()during rendering.Fixes warning introduced in #2985