fix: Allow tippyOptions.getReferenceClientRect in bubble menu to be overridden #2668
Conversation
Prefer using getReferenceClientRect in tippyOptions if available. This allows modifying the position of the bubble menu in a different location for block level elements, like above a table cell or a code block.
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fleon
changed the title
fleon
changed the title
|
Nice idea @fleon. Can you please add your change to the documentation as well so users understand how to use this option? https://github.com/ueberdosis/tiptap/blob/main/docs/api/extensions/bubble-menu.md |
|
@bdbch I don't think this needs to be added to the documentation. The docs already have |
fleon
changed the title
|
Thats true! Thanks for correcting me there. |
|
I'll merge this PR even though the build/test task failed - it seems to be an unrelated timeout issue on the Savvy demo. |
Problem: The bubble menu's position currently depends on prosemirror selection, which works well for inline elements. But for block level elements, like code blocks, if we want to show a bubble menu to do things like change the language of the code block or to delete the code block, it would be ideal to have the bubble menu stick to the top left of the code block, for example.
Solution: Allowing overriding
getReferenceClientRectalong with othertippyOptionssolves this problem and allows customizing the position of tippy outside of the plugin.