feat: Add a generic type for suggestion items #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rfgamaral
force-pushed
the
suggestion-generics
branch
from
f6fc6b2
to
7605cdb
Compare
bdbch
approved these changes
Apr 28, 2022
|
@rfgamaral could you resolve the merge conflicts? Otherwise LGTM! :) |
rfgamaral
force-pushed
the
suggestion-generics
branch
from
7605cdb
to
5b2f60d
Compare
|
@bdbch Done 😊 |
|
Thanks! 🥳 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a generic type for suggestion items, defaulting to
anyas before (no breaking change).