Remove element.current from useEffect in BubbleMenu and FloatingMenu

[ValentaTomas]

Changes to the element.current don't trigger useEffect rerender and shouldn't be used in the dependency array.
One discussion about this is for example here: https://stackoverflow.com/questions/60476155/is-it-safe-to-use-ref-current-as-useeffects-dependency-when-ref-points-to-a-dom

It's also causing some subtle bugs when mounting and unmounting editors.

[netlify]

✔️ Deploy Preview for tiptap-embed ready!

🔨 Explore the source changes: 2c56915

🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61c1ea472ffed20008aa5f06

😎 Browse the preview: https://deploy-preview-2297--tiptap-embed.netlify.app

[philippkuehn]

Hey, in this PR you added also a check for element.current. Can this also be removed then?

And could you do the same change to the FloatingMenu too please?

[ValentaTomas]

Oh thanks, I completely forgot about the FloatingMenu.

I will also fix the element.current issue properly!

[ValentaTomas]

This should be it.

I have some problems with "build / lint (16) (pull_request) Failing after 1m" though - there is an error in the "Commit fixed linting errors" check. @philippkuehn any idea?

error: pathspec 'patch-1' did not match any file(s) known to git
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5) {
  code: 1
}
Error: Invalid status code: 1
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (events.js:210:5)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)

[ValentaTomas]

Please don't merge it yet, I'm still testing some behavior.

[ValentaTomas]

Ok, BubbleMenu looks ok, but I have not tested FloatingMenu. It think it should be ok, but I really don't want to break anything. Do you have automated tests or some sandbox where you test the features?

[hanspagel]

Thanks!

The linting check is broken, but if it would pass you wouldn’t see an exception. You could probably run yarn lint locally to see if there’s something off.

(yarn run lint:fix can help fixing linting issues, but not for all rules)

[ValentaTomas]

lint:fix helped - it was just bad formatting.

When I have the FloatingMenu tested I will notify you here.

[ValentaTomas]

FloatingMenu seems ok too. I think the PR is ready to merge.

[philippkuehn]

looks good. thanks!

[hanspagel]

Thanks for your work! 👏

[ValentaTomas]

No problem. Thank you for creating TipTap.