Selection via Ctrl+A is selecting only first node when last node is table with last cell as empty #3651
Labels
Type: Bug
The issue or pullrequest is related to a bug
Comments
|
This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days |
github-actions
bot
added
the
Info: Stale
|
Commenting as issue is still coming in latest release. (Ref: https://tiptap.dev/examples/tables) |
github-actions
bot
removed
the
Info: Stale
|
I'm facing the exact same problem. |
thet
added a commit
to Patternslib/pat-tiptap
that referenced
this issue
Oct 13, 2023
There is a strange problem with tables and selecting all content with <ctrl>-<a>. When the last node in the document is a table and the last table cell is empty, then pressing <CTRL>-<a> to select everyting only selects the very first node in the document. As soon as one of the conditions - table not the last node or last table cell not empty - is not met, <CTRL>-<a> selects all, as expected. We fix the problem by making sure some content is following the table and add an empty paragraph. When another solution is found we can remove this hack again. More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
thet
added a commit
to Patternslib/pat-tiptap
that referenced
this issue
Oct 13, 2023
There is a strange problem with tables and selecting all content with <ctrl>-<a>. When the last node in the document is a table and the last table cell is empty, then pressing <CTRL>-<a> to select everyting only selects the very first node in the document. As soon as one of the conditions - table not the last node or last table cell not empty - is not met, <CTRL>-<a> selects all, as expected. We fix the problem by making sure some content is following the table and add an empty paragraph. When another solution is found we can remove this hack again. More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
thet
added a commit
to Patternslib/pat-tiptap
that referenced
this issue
Oct 23, 2023
Allow to select all (Ctrl-A, Command-A) with tables in certain conditions. Due to a tiptap/ProseMirror bug tables with some empty cells and no content preceding or following the table, selecting the whole table did not work. This fix makes sure that a non-empty paragraph is added at the end, if no other content is present at the end of the document. More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
thet
added a commit
to Patternslib/pat-tiptap
that referenced
this issue
Oct 23, 2023
Allow to select all (Ctrl-A, Command-A) with tables in certain conditions. Due to a tiptap/ProseMirror bug tables with some empty cells and no content preceding or following the table, selecting the whole table did not work. This fix makes sure that a non-empty paragraph is added at the end, if no other content is present at the end of the document. Follow-up from: - #61 More information here: - ueberdosis/tiptap#2401 - ueberdosis/tiptap#3651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What’s the bug you are facing?
When we have a last node as the table in the editor and its last cell is empty, then if I am trying to select all content of the editor by pressing
Ctrl+Athen only the first node is getting selected.Ref:
The same issue is logged previously here: #2401. This issue is closed without resolution. Here, @philippkuehn pointed out that previously
prosemirror-tableswas used which was causing this bug, but sinceprosemirror-tablesis no longer maintained, this bug was not resolved.As pointed out here, now tiptap maintains an internal fork, can we have this issue resolved or a workaround for now?
Which browser was this experienced in? Are any special extensions installed?
In all browsers.
How can we reproduce the bug on our side?
Follow the attached GIF here: https://tiptap.dev/examples/tables
Can you provide a CodeSandbox?
NA
What did you expect to happen?
Ctrl+Ashould be able to select all the content of editor.Anything to add? (optional)
No
Did you update your dependencies?
Are you sponsoring us?
The text was updated successfully, but these errors were encountered: