Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking selected paragraph opens a random link in said paragraph #275

Closed
gillescoolen opened this issue Apr 26, 2019 · 0 comments · Fixed by #276
Closed

Clicking selected paragraph opens a random link in said paragraph #275

gillescoolen opened this issue Apr 26, 2019 · 0 comments · Fixed by #276

Comments

@gillescoolen
Copy link

gillescoolen commented Apr 26, 2019 •
edited
Loading

Whenever I select a chunk of text and click on a part of said text it opens one of the links inside the text. This can be very irritating whenever someone acidentally triple-clicks on a chunk and opens a link without the intent to do so.

This issue can be reproduced with the example at https://tiptap.scrumpy.io/links. Just select the whole block and click on a selected part.

If my explanation was unclear I'll be able to provide footage if needed.
@gillescoolen gillescoolen changed the title Clicking selected paragraph opens a random link in said paragraph. Clicking selected paragraph opens a random link in said paragraph Apr 26, 2019
Chrissi2812 added a commit to Chrissi2812/tiptap that referenced this issue Apr 29, 2019
@Chrissi2812
fix ueberdosis#275: link click handler no longer open on selection click
44dc533
@Chrissi2812 Chrissi2812 mentioned this issue Apr 29, 2019
Merged
philippkuehn added a commit that referenced this issue Apr 30, 2019
@philippkuehn
Merge pull request #276 from Chrissi2812/issue-275
d1a1dec 
fix #275: link click handler no longer open on selection click
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #275: link click handler no longer open on selection click Chrissi2812/tiptap
1 participant
@gillescoolen