Paste still broken (2.0.0-beta.120)

[nokola]

What’s the bug you are facing?

Pasting things like **bold** or *italic* multiple times doesn't work anymore.

How can we reproduce the bug on our side?

See updated https://codesandbox.io/s/tiptap-after-paste-bug-jjoxc and bug #2002 that still reproduces.

Broken paste in above codesandbox (click to play gif):

And in my project. Note: In my project I have a bit different settings than bold/italic from StarterKit, however used to work before. Not there's data loss, same as bug #2002 (click to play gif)

Can you provide a CodeSandbox?

https://codesandbox.io/s/tiptap-after-paste-bug-jjoxc

What did you expect to happen?

Paste to work without extra characters or losing data.

Anything to add? (optional)

No response

Did you update your dependencies?

• Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

• Yes, I’m a sponsor. 💖

[philippkuehn]

Ah, sorry for these issues. We definitely need to add some tests for these paste rules.

I know what is happening in the first gif. Because it’s already italic from the first paste, italic can’t applied a second time. But that is something I can fix. But note that the second bold is italic too because you pasted at the open end of italic.

The second gif shows a different issue. I would really like to know the config of your pasteRules because there seems to be a data loss. Can you share some code or provide a codesandbox with that config?

[nokola]

No problem! Here's a small repro project for the data loss: https://codesandbox.io/s/tiptap-after-paste-bug2-dataloss-dqq63?file=/src/App.vue

The changes: I added a "quickbold" extension to make bold work with just a single star e.g. *bold* Disabled the existing bold/italic in startupkit.

const starInputRegex = /(?:^|\s)((?:\*)((?:[^*]+))(?:\*))$/gm;
// export const starPasteRegex = /(?:^|\s)((?:\*)((?:[^*]+))(?:\*))/gm;
export const starPasteRegex = /(?:^|\s)((?:\*\*)((?:[^*]+))(?:\*\*))/gm
export const QuickBold = Bold.extend({
    addInputRules() {
        return [markInputRule({ find: starInputRegex, type: this.type })];
    },

    addPasteRules() {
        return [markPasteRule({ find: starPasteRegex, type: this.type })];
    },
});

To reproduce:

1. Open https://codesandbox.io/s/tiptap-after-paste-bug2-dataloss-dqq63?file=/src/App.vue
2. Paste this once and press enter after pasting:

**bold**
*italic*

Expected:
*bold*
italic

Actual:
bold
*talic*

The "i" is lost after pressing Enter.

[nokola]

I know what is happening in the first gif. Because it’s already italic from the first paste, italic can’t applied a second time. But that is something I can fix. But note that the second bold is italic too because you pasted at the open end of italic.

Good insight! :)

[philippkuehn]

found the issue. there is no issue with paste rules but with some input rule regex. input rule regex should not have the gm modifiers. paste rules regex should only have a g modifier. (see: 65eddf0)