Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better types for event emitter #1898

Closed
philippkuehn opened this issue Sep 16, 2021 · 2 comments · Fixed by #1959
Closed

Add better types for event emitter #1898

philippkuehn opened this issue Sep 16, 2021 · 2 comments · Fixed by #1959
Assignees
@philippkuehn
Labels
Type: Feature The issue or pullrequest is a new feature

Comments

@philippkuehn
Copy link
Contributor

editor.on() and editor.off() need some better types, so it will show the correct event names and props instead of a generic string and Function.
@philippkuehn philippkuehn added Type: Feature The issue or pullrequest is a new feature v2 labels Sep 16, 2021
@HuiiBuh
Copy link
Contributor

HuiiBuh commented Sep 28, 2021

I already implemented something like this for my angular wrapper.
Do you mind if I have a go?

@philippkuehn
Copy link
Contributor Author

Happy for any PR!

@hanspagel hanspagel removed the v2 label Sep 28, 2021
HuiiBuh added a commit to HuiiBuh/tiptap that referenced this issue Sep 29, 2021
@HuiiBuh
feat: ueberdosis#1898 Made the EventEmitter generic to improve the ty…
ab2e7a4 
…pes of the tiptap events
@HuiiBuh HuiiBuh mentioned this issue Sep 29, 2021
Merged
philippkuehn pushed a commit that referenced this issue Sep 30, 2021
@HuiiBuh
feat: #1898 Made the EventEmitter generic to improve the types of the…
54e85fd 
… tiptap events (#1959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippkuehn philippkuehn

Labels
Type: Feature The issue or pullrequest is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added better types for event emitter HuiiBuh/tiptap
3 participants
@hanspagel @philippkuehn @HuiiBuh