-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Losing text selection / focus in mobile browsers #1806
Comments
What if you add event.preventDefault to the buttons? |
Ah, okay. 😛 |
Thanks for the quick fix on iOS! 🙌 But I think the issue is still happening with Chrome Android, for both Vue and React in the default example. |
it’s fixed in the packages but we have to update the demos 😅 |
@philippkuehn Can you check on an Android phone if this is really fixed? I tried on two different devices, latest Chrome, and the virtual keyboard still slides up and down… (this doesn’t happen on the main demo of the ProseMirror website, for comparison) |
This approach soves the Problem on most* Devices. Used in am button with react:
... if someona has any idea, I'm happy about every hint |
Ha! This seems to work.
|
You can also use ProseMirror's
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…ed preventing of default event and calling of ProseMirror's "EditorView.focus()" (to fix the virtual keyboard slides up and down behavior, when clicking editor menu buttons). Details (related GitHub issue): - "Losing text selection / focus in mobile browsers" ueberdosis/tiptap#1806
Description
When toggling marks or nodes with buttons, the virtual keyboard slides up and down, and in some cases (iOS Safari) loses the text selection entirely and doesn't slide back.
I believe this is a newly introduced bug, I have a build from 2021-08-09 behaving normally.
Steps to reproduce the bug
Steps to reproduce the behavior:
Expected behavior
Text selection should stay focused.
The text was updated successfully, but these errors were encountered: