Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists not being joined on toggleList #1329

Closed
YousefED opened this issue May 17, 2021 · 2 comments · Fixed by #2260
Closed

Lists not being joined on toggleList #1329

YousefED opened this issue May 17, 2021 · 2 comments · Fixed by #2260
Labels
sponsor 💖 This issue or pull request was created by a Tiptap sponsor Type: Bug The issue or pullrequest is related to a bug

Comments

@YousefED
Copy link
Contributor

When you use toggleList, the new list is not joined with lists above / below.

Bug demonstration:
list bug

I'd expect it to behave similar to when I type the "- " shortcut to create a list:
list ok

The WrappingInputRule takes this scenario into account (https://github.com/ProseMirror/prosemirror-inputrules/blob/master/src/rulebuilders.js), but toggleList does not.

I think this should happen automatically (join with lists above / below), or be an option for the toggleList command.

@YousefED YousefED added Type: Bug The issue or pullrequest is related to a bug v2 labels May 17, 2021
@github-actions github-actions bot added the sponsor 💖 This issue or pull request was created by a Tiptap sponsor label May 17, 2021
@philippkuehn
Copy link
Contributor

Ah yeah that makes sense!

@YousefED
Copy link
Contributor Author

Related; ProseMirror WrappingInputRule actually only joins with items above. I think it might also make sense to join with items below (when typing "-" above an existing list). Let me know if you'd like me to open a separate issue for this

@hanspagel hanspagel removed the v2 label Sep 28, 2021
philippkuehn added a commit that referenced this issue Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsor 💖 This issue or pull request was created by a Tiptap sponsor Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants