fix: Prevent drag event from being ignored

ueberdosis · Feb 7, 2023 · db0c0d1 · db0c0d1
1 parent e958128
commit db0c0d1
Showing 1 changed file with 13 additions and 17 deletions.
diff --git a/packages/core/src/NodeView.ts b/packages/core/src/NodeView.ts
@@ -113,11 +113,12 @@ export class NodeView<
       return false
     }
 
+    const isDragEvent = event.type.startsWith('drag')
     const isDropEvent = event.type === 'drop'
     const isInput = ['INPUT', 'BUTTON', 'SELECT', 'TEXTAREA'].includes(target.tagName) || target.isContentEditable
 
     // any input event within node views should be ignored by ProseMirror
-    if (isInput && !isDropEvent) {
+    if (isInput && !isDropEvent && !isDragEvent) {
       return true
     }
 
@@ -129,7 +130,6 @@ export class NodeView<
     const isPasteEvent = event.type === 'paste'
     const isCutEvent = event.type === 'cut'
     const isClickEvent = event.type === 'mousedown'
-    const isDragEvent = event.type.startsWith('drag')
 
     // ProseMirror tries to drag selectable nodes
     // even if `draggable` is set to `false`
@@ -151,21 +151,17 @@ export class NodeView<
       if (isValidDragHandle) {
         this.isDragging = true
 
-        document.addEventListener(
-          'dragend',
-          () => {
-            this.isDragging = false
-          },
-          { once: true },
-        )
-
-        document.addEventListener(
-          'mouseup',
-          () => {
-            this.isDragging = false
-          },
-          { once: true },
-        )
+        document.addEventListener('dragend', () => {
+          this.isDragging = false
+        }, { once: true })
+
+        document.addEventListener('drop', () => {
+          this.isDragging = false
+        }, { once: true })
+
+        document.addEventListener('mouseup', () => {
+          this.isDragging = false
+        }, { once: true })
       }
     }