-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make transformer
compatible with @tiptap/core@^2.0.0-beta.210
#512
fix: make transformer
compatible with @tiptap/core@^2.0.0-beta.210
#512
Conversation
transformer
compatible with @tiptap/[email protected]^
transformer
compatible with @tiptap/core@^2.0.0-beta.210
c2e28ee
to
426258d
Compare
@Deckluhm thanks for this! There seem to be a few issues right now on TipTap-Side, so if possible I'd just wait a bit more and then directly move to the fixed version (probably once ueberdosis/tiptap#3720 is merged) |
I wasn't aware of this Tiptap issue since If the issue is impacting |
426258d
to
6bad147
Compare
6bad147
to
ccc798c
Compare
It got merged a few hours ago so I just updated my PR with |
I thought about this for a few minutes and I think having those types imported directly from the project would be cleaner and/or easier to use and discover. Example:
or
but I'd stick with the first one. I think this should already work with a lot of existing typings but it seems some are not exported from the entryfile / entry types file. |
Obv. we would need to change this in the @tiptap/core package though. |
|
Is there anything preventing the merge of this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Deckluhm Thanks! I've just pushed an update to .217 and will merge soon :)
Fixes #510
Ideally it would be great to merge #511 first.