Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make transformer compatible with @tiptap/core@^2.0.0-beta.210 #512

Conversation

Deckluhm
Copy link
Collaborator

@Deckluhm Deckluhm commented Feb 7, 2023

Fixes #510

Ideally it would be great to merge #511 first.

@Deckluhm Deckluhm changed the title fix: make transformer compatible with @tiptap/[email protected]^ fix: make transformer compatible with @tiptap/core@^2.0.0-beta.210 Feb 7, 2023
@janthurau
Copy link
Collaborator

janthurau commented Feb 7, 2023

@Deckluhm thanks for this! There seem to be a few issues right now on TipTap-Side, so if possible I'd just wait a bit more and then directly move to the fixed version (probably once ueberdosis/tiptap#3720 is merged)

@Deckluhm
Copy link
Collaborator Author

Deckluhm commented Feb 8, 2023

I wasn't aware of this Tiptap issue since @tiptap/core@^2.0.0-beta.210 is working fine on my side with this PR.

If the issue is impacting @tiptap/core, we can definitely wait for the PR to be merged 👍

@Deckluhm
Copy link
Collaborator Author

Deckluhm commented Feb 8, 2023

It got merged a few hours ago so I just updated my PR with @tiptap/core@^2.0.0-beta.214 (which is the minimum required version to get the fix).

@svenadlung
Copy link
Contributor

svenadlung commented Feb 8, 2023

@Deckluhm I think 214 restores the old path 😂 But still I think your way of importing is even better.
@bdbch what do you think?

@bdbch
Copy link
Contributor

bdbch commented Feb 9, 2023

I thought about this for a few minutes and I think having those types imported directly from the project would be cleaner and/or easier to use and discover.

Example:

import { Extensions } from '@tiptap/core

or

import { Extensions } from '@tiptap/core/types'

but I'd stick with the first one. I think this should already work with a lot of existing typings but it seems some are not exported from the entryfile / entry types file.

@bdbch
Copy link
Contributor

bdbch commented Feb 9, 2023

Obv. we would need to change this in the @tiptap/core package though.

@Deckluhm
Copy link
Collaborator Author

Deckluhm commented Feb 9, 2023

Obv. we would need to change this in the @tiptap/core package though.

import { Extensions } from '@tiptap/core is already possible with current @tiptap/core.

@Deckluhm
Copy link
Collaborator Author

Is there anything preventing the merge of this PR?

Copy link
Collaborator

@janthurau janthurau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Deckluhm Thanks! I've just pushed an update to .217 and will merge soon :)

@janthurau janthurau merged commit 591103f into ueberdosis:main Feb 15, 2023
@Deckluhm Deckluhm deleted the @hocuspocus/transformer+@tiptap/[email protected] branch February 15, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@hocuspocus/transformer and @tiptap/[email protected] are incompatible
4 participants