Update Jose to support OTP24 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
approved these changes
Jun 4, 2021
|
🚀 |
|
A new release with this would be awesome, it's currently preventing us too from upgrading to OTP 24. Thanks for all your hard work! |
|
Is this lib abandoned? A release would be great. any workarounds? |
|
@atomkirk the updated version has actually been released: https://hex.pm/packages/guardian/2.2.0 |
|
Oh, any idea why its not updated here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In are moving our apps to OTP24 / Elixir 1.12 and as guardian is still using an outdated Jose version, we were unable to upgrade due to the a deprecated function:
This PR updates Jose and also updates 1 function that Guardian uses from Jose that has also changed.
These seemed to have worked for our apps, but I am really not sure if it is this simple. I wanted to push this back to you guys so you can check if this is as simple as updating this or if it is more involved than that.
Looking forward to what you guys think. In the meantime I'll use my fork to test our apps with these changes. If I do encounter any issues, I'll be sure to flag them here as well.