Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop vova -> latest #27

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Develop vova -> latest #27

merged 3 commits into from
Apr 3, 2024

Conversation

planv
Copy link
Contributor

@planv planv commented Mar 20, 2024

  • fixed JS errors that block creating keys
  • added new GitHub Action to create SBOM and release

@planv planv changed the title Develop vova Develop vova -> latest Mar 20, 2024
@planv planv requested review from kavaribes and fqjony March 20, 2024 19:49
@fqjony
Copy link
Contributor

fqjony commented Mar 26, 2024

@planv, so, do we need the temp branch and draft release to attach the sbom artifact, or is there any other reason to do it that way? Just for my understanding.

@planv
Copy link
Contributor Author

planv commented Mar 26, 2024

@planv, so, do we need the temp branch and draft release to attach the sbom artifact, or is there any other reason to do it that way? Just for my understanding.

Yes, and also for cleaning up files that should not be included to release.

But it looks like it is an old version, and I have already improved it here - https://github.com/udx/docker-site/blob/latest/.github/workflows/build-and-release.yml

We have to implement 1 process that we will use to deploy our Docker Images - Docker Site, Docker SFTP, Rabbit Updater etc

@planv planv temporarily deployed to develop-vova April 1, 2024 18:20 — with GitHub Actions Inactive
@planv
Copy link
Contributor Author

planv commented Apr 1, 2024

@fqjony @kavaribes I removed GitHub Action. It will be refactored and then I'll commit it.
Let's release fixes for now

@planv planv merged commit e719e71 into latest Apr 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants