Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest -> master #17

Merged
merged 8 commits into from
Feb 5, 2024
Merged

latest -> master #17

merged 8 commits into from
Feb 5, 2024

Conversation

planv
Copy link
Contributor

@planv planv commented Feb 2, 2024 •
edited
Loading

Changelog:

  • updated NodeJS version to 20
  • updated NodeJS Modules to the latest versions
  • fixed issue with SFTP connection
  • prevented access for the root user
  • added processing SLACK_NOTIFICACTION_CHANNEL and SLACK_NOTIFICACTION_URL environment variables in GitHub Action
  • updated GitHub Action Build and Deploy to GKE
  • added additional logging (information about connection)

@planv planv requested review from kavaribes and fqjony February 2, 2024 05:56
kavaribes
kavaribes approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@kavaribes kavaribes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@planv planv merged commit 7f16556 into master Feb 5, 2024
3 checks passed
@fqjony
Copy link
Contributor

fqjony commented Feb 16, 2024

@planv, just a reminder that we have the following doc https://udx.atlassian.net/wiki/spaces/UDXI/pages/1677656065/Docker+SFTP
please feel free to add/update anything you think is related.

@planv
Copy link
Contributor Author

planv commented Feb 16, 2024

please feel free to add/update anything you think is related.

Added information about ability to connect to production containers and preventing root access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavaribes kavaribes kavaribes approved these changes

@fqjony fqjony Awaiting requested review from fqjony

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@planv @fqjony @kavaribes