### 0.2.7 #16
Merged
### 0.2.7 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planv
reviewed
Jan 22, 2024
bin/controller.keys.js
Outdated
| @@ -28,6 +28,8 @@ var _ = require('lodash'); | |||
| module.exports.updateKeys = function updateKeys(options, taskCallback) { | |||
|
|
|||
| let roles = process.env.ALLOW_SSH_ACCESS_ROLES || "admin,maintain,write"; | |||
| let productionBranch = process.env.PRODUCTION_BRANCH || "production"; | |||
| let adminRole = process.env.ADMIN_ROLE || "admin"; | |||
There was a problem hiding this comment.
ALLOW_PRODUCTION_SSH_ACCES_ROLES?- and change it from string to array
what do you think ?
There was a problem hiding this comment.
add ability connect to production containers for Administrators
It's from task.
@planv
There was a problem hiding this comment.
Yes, it is needed in our case.
But we also have to provide ability to expand this value.
planv
approved these changes
Jan 22, 2024
planv
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.2.7