Updates AWS managed policies

[udondan]

Updates AWS managed policies

Summary by CodeRabbit

• New Permissions
  • AWS Backup Service Linked Role Policy: Added permission to tag RDS tenant database snapshots
  • AWS Backup Service Role Policy: Enabled creation and deletion of tenant databases
  • ReadOnlyAccess Policy: Added read permissions for Access Analyzer, Amplify, and AWS Support services

[coderabbitai]

Walkthrough

This pull request introduces updates to three AWS IAM policy documents. The changes primarily focus on expanding permissions for AWS services. In the AWSBackupServiceLinkedRolePolicyForBackup.json, a new statement is added to allow tagging RDS tenant database snapshots. The AWSBackupServiceRolePolicyForRestores.json gains permissions for creating and deleting tenant databases. The ReadOnlyAccess.json policy is enhanced with additional read-only permissions for services like Access Analyzer, Amplify, and AWS Support.

Changes

File	Change Summary
docs/source/_static/managed-policies/AWSBackupServiceLinkedRolePolicyForBackup.json	Added new statement "RDSSnapshotTenantDatabasePermissions" to allow rds:AddTagsToResource for tenant database snapshots
docs/source/_static/managed-policies/AWSBackupServiceRolePolicyForRestores.json	Added rds:CreateTenantDatabase and rds:DeleteTenantDatabase actions to "RDSPermissions" statement
docs/source/_static/managed-policies/ReadOnlyAccess.json	Added multiple read-only permissions for Access Analyzer, Amplify, and AWS Support services

Possibly related PRs

• Updates AWS managed policies #711: Changes to AWSBackupServiceLinkedRolePolicyForBackup.json involving RDS permissions
• Updates AWS managed policies #878: Updates to AWSBackupServiceRolePolicyForBackup.json with RDS-related permission modifications

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff1d007 and 5f6c8ad.

📒 Files selected for processing (3)

• docs/source/_static/managed-policies/AWSBackupServiceLinkedRolePolicyForBackup.json (1 hunks)
• docs/source/_static/managed-policies/AWSBackupServiceRolePolicyForRestores.json (1 hunks)
• docs/source/_static/managed-policies/ReadOnlyAccess.json (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: Test cdk-iam-floyd
• GitHub Check: Automerge CI

🔇 Additional comments (3)

docs/source/_static/managed-policies/ReadOnlyAccess.json (1)

2257-2271: LGTM! The added AWS Support permissions maintain read-only access.

The new permissions are appropriately scoped to read-only operations (Describe*, Search*) for AWS Support service, which aligns with the policy's purpose of providing read-only access across AWS services.

docs/source/_static/managed-policies/AWSBackupServiceLinkedRolePolicyForBackup.json (1)

138-147: LGTM - New RDS tenant database permissions follow security best practices

The new statement follows the principle of least privilege by:

• Limiting to only the required action (rds:AddTagsToResource)
• Properly scoping the resource to AWS Backup managed snapshots
• Maintaining consistency with existing RDS permissions

Let's verify that this is the standard ARN pattern for RDS tenant database snapshots:

✅ Verification successful

Verified: RDS tenant database snapshot ARN pattern is correct

The ARN pattern arn:aws:rds:*:*:snapshot-tenant-database:awsbackup:* is confirmed valid based on:

• Consistent with AWS Backup's RDS snapshot naming convention
• Explicitly documented in changelog v0.601.0
• Part of a complete tenant database feature set including related API actions

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Verify the ARN pattern for RDS tenant database snapshots
rg "arn:aws:rds:.+:snapshot-tenant-database:" --type json

Length of output: 204

---

Script:

#!/bin/bash
# Search for other RDS snapshot ARN patterns and documentation
echo "=== RDS Snapshot ARN Patterns ==="
rg "arn:aws:rds:.+:snapshot" --type json -A 1 -B 1

echo -e "\n=== Tenant Database Documentation ==="
rg -i "tenant.?database" --type md --type txt

Length of output: 2148

docs/source/_static/managed-policies/AWSBackupServiceRolePolicyForRestores.json (1)

102-104: LGTM - New RDS tenant database actions are consistent with existing permissions

The addition of rds:CreateTenantDatabase and rds:DeleteTenantDatabase actions:

• Logically belongs with other RDS restore operations
• Maintains consistency with existing permission patterns

Let's verify if these actions support resource-level permissions:

✅ Verification successful

Verified: Resource-level permissions not supported for new RDS tenant actions

The broad resource access ("Resource": "*") is appropriate as:

• These appear to be new RDS features (found in recent changelog)
• No evidence of resource-level permission support
• Consistent with other RDS actions in the AWS Backup service role

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any existing resource-level constraints for these actions
rg "rds:(Create|Delete)TenantDatabase.+Resource" --type json

# Check if these are standard actions in AWS managed policies
gh api graphql -f query='
{
  search(query: "rds:CreateTenantDatabase rds:DeleteTenantDatabase repo:aws/aws-sdk", type: CODE, first: 5) {
    nodes {
      ... on SearchResult {
        textMatches {
          fragment
        }
      }
    }
  }
}'

Length of output: 987

---

Script:

#!/bin/bash
# Search for tenant-related RDS actions in documentation and policies
rg "rds:.+Tenant.+|Tenant.+rds:" --type json

# Search for any documentation files mentioning these actions
fd -e md -e txt | xargs rg "CreateTenantDatabase|DeleteTenantDatabase"

# Search for similar RDS actions with resource constraints
rg '"Resource":.+\*rds:.+' --type json -A 2 -B 2

Length of output: 499

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.