fix: ensure all expected files are included in the resulting package (#…

…300)

* fix: ensure all expected files are included in the resulting package

* Update Makefile

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* fix: make target

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

.github/workflows/publish.yml

@@ -27,7 +27,10 @@ jobs:
           sudo apt-get install -y tree
 
       - name: Build source w/ jsii
-        run: npx jsii
+        run: |
+          lambda/build
+          npx jsii
+          make validate-package
 
       - name: Build packages w/ jsii-pacmak
         run: |

.github/workflows/test.yml

@@ -92,7 +92,10 @@ jobs:
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
 
       - name: Build source w/ jsii
-        run: npx jsii
+        run: |
+          lambda/build
+          npx jsii
+          make validate-package
 
       - name: Build packages w/ jsii-pacmak
         run: |

.npmignore

@@ -26,6 +26,7 @@ tsconfig.tsbuildinfo
 .eslintrc
 .prettierrc
 tsconfig-lint.json
+publish_output.txt
 
 lambda/*
 !lambda/code.zip

Makefile

@@ -24,3 +24,21 @@ eslint:
 	@echo -e "$(TARGET_COLOR)Running eslint $$(npx eslint --version)$(NO_COLOR)"
 	@npx eslint .; \
 	echo "Passed"
+
+validate-package:
+	@echo -e "$(TARGET_COLOR)Checking package content$(NO_COLOR)"
+	@npm publish --dry-run 2>&1 | tee publish_output.txt
+	@\
+	FILES_TO_CHECK="lambda/code.zip lib/index.d.ts lib/index.js lib/types.d.ts lib/types.js"; \
+	MISSING_FILES=""; \
+	for file in $$FILES_TO_CHECK; do \
+		if ! grep -q $$file publish_output.txt; then \
+			MISSING_FILES="$$MISSING_FILES $$file"; \
+		fi; \
+	done; \
+	if [ -n "$$MISSING_FILES" ]; then \
+		echo "❌ The following files are NOT included in the package:$$MISSING_FILES"; \
+		rm publish_output.txt; \
+		exit 1; \
+	fi
+	@rm publish_output.txt