[md-serializer] add br html element rule for md serialize #3223
Conversation
🦋 Changeset detectedLatest commit: d27d9f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -294,7 +294,7 @@ describe('deserializeMd', () => { | |||
| <fragment> | |||
| <hp> | |||
| <htext>Line 1</htext> | |||
| <htext>{'\n'}</htext> | |||
| <htext>{'<br>'}</htext> | |||
There was a problem hiding this comment.
Expecting this to return a text node containing the string '<br>' doesn't seem right to me
| <hp> | ||
| <htext></htext> | ||
| </hp> |
There was a problem hiding this comment.
Nesting paragraphs isn't valid HTML markup. I think \n is the only natural choice for deserializing a <br> element.
There was a problem hiding this comment.
Yes, but how you will detect \n when serialising it back to <br>?
There was a problem hiding this comment.
You could convert all \n characters occuring in text nodes to <br>, or just keep them as \ns. That would be the most natural choice for the majority of Plate's users; if you need something different in your app, it might be best to do that in your own source code.
Summary
Add
<br/>serialize formd.