Toggle > Handle deleteForward before a non-selectable and deleteBackward after a non-selectable #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3cca1ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Liboul
force-pushed
the
liboul/toggle/fix/delete-backward-forward
branch
from
d9df5cf
to
516a2ac
Compare
…ard after a non-selectable
Liboul
force-pushed
the
liboul/toggle/fix/delete-backward-forward
branch
from
516a2ac
to
4f2eb34
Compare
zbeyens
previously approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After extensively testing the toggle plugin, I've found that the behaviour of
deleteBackwardwas not deterministic. This PR ensures that it is.The right behaviour of
deleteBackward, in case the cursor is right after a closed toggle, is to merge the current node with the toggle, bypassing the hidden content.Similarly, the right behaviour of
deleteForward, in case the cursor is right before a closed toggle, is to merge the current node with the toggle, bypassing the hidden content.This behaviour would be rendered useless in case a
isHiddenprop becomes available in Slate, but for now this is the best I could come up with.Screen.Recording.2024-02-01.at.04.31.35.mov