Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final model update #45

Merged
merged 15 commits into from
Oct 31, 2024
Merged

Final model update #45

merged 15 commits into from
Oct 31, 2024

Conversation

samgdotson
Copy link
Member

@samgdotson samgdotson commented Oct 28, 2024

This PR adds several features to the model

  1. PTC and ITC policies
  2. Technology-specific WACC values
  3. Scripts to run an advanced nuclear sensitivity -- if desired.
  4. Variable wind turbine capacity factors (i.e., users can now specify the capacity factor for a particular vintage of wind turbine).
  5. Updates the sensitivity script to run a new range of growth scenarios.
  6. Updates the "no export" starting demand from 136 TWh to 140 TWh to reflect the average value from the last 25 years (rather than a more recent data point from 2019).

@samgdotson samgdotson added Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:2-Challenging This issue may be complex or require specialized skills. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) labels Oct 28, 2024
@samgdotson samgdotson added this to the Final model run milestone Oct 28, 2024
@samgdotson samgdotson self-assigned this Oct 28, 2024
@pep8speaks
Copy link

Hello @samgdotson! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:1: W293 blank line contains whitespace
Line 30:1: E722 do not use bare 'except'
Line 32:1: W293 blank line contains whitespace
Line 35:1: E722 do not use bare 'except'
Line 78:1: W293 blank line contains whitespace
Line 79:5: E303 too many blank lines (2)
Line 329:1: W293 blank line contains whitespace
Line 330:1: W293 blank line contains whitespace
Line 331:17: E303 too many blank lines (2)
Line 332:80: E501 line too long (80 > 79 characters)
Line 342:80: E501 line too long (83 > 79 characters)
Line 548:60: E225 missing whitespace around operator
Line 548:80: E501 line too long (98 > 79 characters)
Line 588:1: W293 blank line contains whitespace
Line 589:60: W291 trailing whitespace
Line 590:1: W293 blank line contains whitespace
Line 591:80: E501 line too long (92 > 79 characters)
Line 591:93: W291 trailing whitespace
Line 592:80: E501 line too long (98 > 79 characters)
Line 592:99: W291 trailing whitespace
Line 593:80: E501 line too long (83 > 79 characters)
Line 594:1: W293 blank line contains whitespace
Line 596:66: W291 trailing whitespace
Line 597:80: E501 line too long (96 > 79 characters)
Line 597:97: W291 trailing whitespace
Line 598:54: E128 continuation line under-indented for visual indent
Line 598:80: E501 line too long (99 > 79 characters)
Line 598:100: W291 trailing whitespace
Line 599:80: E501 line too long (103 > 79 characters)

Line 12:80: E501 line too long (82 > 79 characters)
Line 14:1: W293 blank line contains whitespace
Line 15:80: E501 line too long (100 > 79 characters)
Line 16:1: W293 blank line contains whitespace
Line 19:1: W293 blank line contains whitespace
Line 20:80: E501 line too long (104 > 79 characters)
Line 24:80: E501 line too long (111 > 79 characters)
Line 25:1: W293 blank line contains whitespace
Line 27:1: W293 blank line contains whitespace
Line 28:80: E501 line too long (86 > 79 characters)
Line 29:1: W293 blank line contains whitespace
Line 32:1: W293 blank line contains whitespace
Line 33:69: W292 no newline at end of file

Line 52:52: W291 trailing whitespace
Line 53:48: W291 trailing whitespace
Line 54:41: W291 trailing whitespace
Line 55:41: W291 trailing whitespace
Line 56:41: W291 trailing whitespace
Line 58:1: W293 blank line contains whitespace
Line 59:35: W291 trailing whitespace
Line 60:53: W291 trailing whitespace
Line 61:43: W291 trailing whitespace
Line 62:44: W291 trailing whitespace
Line 65:1: W293 blank line contains whitespace
Line 73:1: W293 blank line contains whitespace
Line 85:1: W293 blank line contains whitespace
Line 88:1: W293 blank line contains whitespace
Line 90:1: W293 blank line contains whitespace
Line 91:44: W291 trailing whitespace
Line 96:1: W293 blank line contains whitespace
Line 97:59: E231 missing whitespace after ','
Line 98:47: E231 missing whitespace after ':'
Line 99:69: E225 missing whitespace around operator
Line 99:78: W291 trailing whitespace
Line 100:80: E501 line too long (83 > 79 characters)
Line 101:69: E225 missing whitespace around operator
Line 101:79: W291 trailing whitespace
Line 102:80: E501 line too long (88 > 79 characters)
Line 103:1: W293 blank line contains whitespace
Line 104:57: E231 missing whitespace after ','
Line 104:70: E231 missing whitespace after ','
Line 104:80: E501 line too long (94 > 79 characters)
Line 105:1: W293 blank line contains whitespace
Line 106:1: W293 blank line contains whitespace
Line 107:5: E303 too many blank lines (2)
Line 107:52: W291 trailing whitespace
Line 108:80: E501 line too long (85 > 79 characters)
Line 109:80: E501 line too long (90 > 79 characters)
Line 158:30: W291 trailing whitespace
Line 159:30: W291 trailing whitespace
Line 160:15: W291 trailing whitespace
Line 161:26: W291 trailing whitespace
Line 162:37: E231 missing whitespace after ','
Line 163:37: E231 missing whitespace after ','
Line 163:57: E231 missing whitespace after ','
Line 172:80: E501 line too long (89 > 79 characters)
Line 173:80: E501 line too long (89 > 79 characters)
Line 177:31: W291 trailing whitespace
Line 178:17: E128 continuation line under-indented for visual indent
Line 178:39: W291 trailing whitespace
Line 179:17: E128 continuation line under-indented for visual indent
Line 179:30: W291 trailing whitespace
Line 180:17: E128 continuation line under-indented for visual indent
Line 181:31: W291 trailing whitespace
Line 182:17: E128 continuation line under-indented for visual indent
Line 182:39: W291 trailing whitespace
Line 183:17: E128 continuation line under-indented for visual indent
Line 183:30: W291 trailing whitespace
Line 184:17: E128 continuation line under-indented for visual indent

Line 16:28: E262 inline comment should start with '# '

@samgdotson samgdotson changed the title Adv nuclear test Final model update Oct 28, 2024
@samgdotson samgdotson requested a review from lshaver October 28, 2024 17:51
@samgdotson samgdotson marked this pull request as ready for review October 28, 2024 17:51
Copy link
Contributor

@lshaver lshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for wrapping all of this up in a final PR!

@lshaver lshaver merged commit 1ebfe02 into main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Analysis This issue has to do with the analysis component of the code or document. (plots, postprocessing) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Difficulty:2-Challenging This issue may be complex or require specialized skills. Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants