Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fossil fuel retirements #39

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Fossil fuel retirements #39

merged 6 commits into from
Sep 11, 2024

Conversation

samgdotson
Copy link
Member

This PR

  • closes Add energy carrier constraint #32 by adding an "operational limit" constraint to existing coal and natural gas plants that restricts their total annual generation to the product of the carrier's remaining capacity and the number of snapshots (i.e., hours) in the model year. Currently, there are two phases of retirements. 2030, 2035 for coal, and 2045 for natural gas.
  • closes Add rule to plot workflow dag #33 by adding a rule to the snakemake file to build the directed acyclic graph (DAG).

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request labels Sep 4, 2024
@samgdotson samgdotson added this to the 2nd Set of Model Runs milestone Sep 4, 2024
@samgdotson samgdotson self-assigned this Sep 4, 2024
@pep8speaks
Copy link

pep8speaks commented Sep 4, 2024

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 391:1: W293 blank line contains whitespace
Line 393:1: W293 blank line contains whitespace
Line 397:1: W293 blank line contains whitespace
Line 404:1: W293 blank line contains whitespace
Line 406:1: W293 blank line contains whitespace
Line 408:25: E127 continuation line over-indented for visual indent
Line 409:25: E127 continuation line over-indented for visual indent
Line 410:25: E127 continuation line over-indented for visual indent
Line 411:25: E127 continuation line over-indented for visual indent
Line 412:25: E127 continuation line over-indented for visual indent
Line 413:25: E127 continuation line over-indented for visual indent
Line 414:25: E124 closing bracket does not match visual indentation
Line 417:1: W293 blank line contains whitespace
Line 419:1: W293 blank line contains whitespace
Line 479:5: E303 too many blank lines (2)
Line 500:80: E501 line too long (81 > 79 characters)

Comment last updated at 2024-09-04 15:23:49 UTC

@samgdotson samgdotson merged commit 9d14b72 into main Sep 11, 2024
@samgdotson samgdotson deleted the energy-constraint branch September 11, 2024 13:19
@samgdotson samgdotson mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) Type:Feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rule to plot workflow dag Add energy carrier constraint
2 participants