Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugging PR #31

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Debugging PR #31

merged 10 commits into from
Aug 27, 2024

Conversation

samgdotson
Copy link
Member

@samgdotson samgdotson commented Aug 27, 2024 •
edited
Loading

This pull request accomplishes a few things

  1. Closes Model does not use natural gas capacity #28 (thanks for your help @jruzekow)
  2. Adds wild cards to the Snakefile output files to help with data organization.
  3. Removes the carbon constraints to enable use of natural gas.
  4. Removes the minimum power constraint on nuclear power.
  5. Reduces the natural gas price to allow the model to deploy natural gas.
  6. The model is feasible with existing Illinois capacity.

Current known issues:

  1. Although the model uses natural gas now, it does not use any of its coal capacity. This will (hopefully) be remedied in a future PR that addresses issues Add rule to collect time series data for fuel costs #29 and Update add electricity to add time series cost data for coal and natural gas #30.
  2. The model only optimizes a single year. We need to look a bit farther ahead. This will (hopefully) be addressed by constraining the energy carriers rather than the co2 emissions.

Further notes

This version of PyPSA (0.28.0) does not curtail energy from thermal generators. This led to the infeasibility previously noted by @jruzekow.

Edit:

For reviewers

It would be extremely helpful if reviewers could update the "End date" field once the PR has been approved and merged. Thanks!

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Comp:Output This issue has to do with the output component of the code or document. (writing to databases, etc. Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR) labels Aug 27, 2024
@samgdotson samgdotson added this to the 2nd Set of Model Runs milestone Aug 27, 2024
@samgdotson samgdotson requested a review from lshaver August 27, 2024 13:28
@samgdotson samgdotson self-assigned this Aug 27, 2024
@pep8speaks
Copy link

pep8speaks commented Aug 27, 2024 •
edited
Loading

Hello @samgdotson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-08-27 13:42:07 UTC

@samgdotson samgdotson requested a review from ssattler August 27, 2024 13:57
lshaver
lshaver reviewed Aug 27, 2024
View reviewed changes
scripts/add_electricity.py
ramp_limit_up = 1.0
ramp_limit_down = 1.0
p_nom_min = p_nom

# minimum/maximum power output
if tech == 'LWR':
p_min_pu = 0.95
p_max_pu = 1.0
p_min_pu = 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that would be nice to get these numeric values (and any others) moved over to the config file in a future PR.

lshaver
lshaver approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@lshaver lshaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run the file and get results. Code changes seem reasonable with a lot of focus on refactoring, whitespace changes, etc.

@lshaver lshaver merged commit 1eb398d into main Aug 27, 2024
@samgdotson samgdotson deleted the tech_details branch August 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lshaver lshaver lshaver approved these changes

@ssattler ssattler Awaiting requested review from ssattler

Assignees

@samgdotson samgdotson

Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Comp:Input This issue has to do with the input component of the code or document. (input parameters, prep) Comp:Output This issue has to do with the output component of the code or document. (writing to databases, etc. Difficulty:1-Beginner This issue does not require expert knowledge and may be a good issue for new contributors. Priority:1-Critical This is the highest priority (i.e. it is blocking other work or facing a deadline). Status:5-In Review This issue has been handled, and the solution is being reviewed. (probably as a PR)
Projects
None yet
Milestone
2nd Set of Model Runs
Development

Successfully merging this pull request may close these issues.

Model does not use natural gas capacity
3 participants
@samgdotson @pep8speaks @lshaver