Adds coal, nuclear, and CCGT generators to the model #15
Conversation
Also modifies NREL data scripts and notebook to expose user data for easier usage/editing.
There was a problem hiding this comment.
Nice job on this! Thanks for cleaning up some of the other files, as well. Approving.
The only things I changed were the gitignore file, which wasn't properly tracking (or ignoring) the files you added. The second thing I changed was just the formatting on the note you added to the readme. Here's a nice short explanation on the GitHub markdown formatting I used.
Lastly, the assignee is generally the person working on / making the pull request! By extension, the assignee on a pull request should be the same person assigned to a corresponding issue. Since you were assigned to issue #4, you should also be assigned to the PR closing that issue (this one)!
Did PyPSA seem straightforward to add technologies to?
|
Awesome, that all makes sense! I'm still learning my way around PyPSA, but it seems pretty straightforward. Most of my time working on this PR was me clearing out the cobwebs since it's been a while since I've worked in Github. |
This pull request closes #4 by adding coal, nuclear, and CCGT to the Illinois model notebook. The model runs successfully. A handful of minor issues from the previous pull request are also addressed.