Replace certificate language in lms and core #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasawernawaz
approved these changes
Feb 21, 2020
| @@ -44,7 +44,7 @@ export class PortfolioExperimentUpsellModal extends React.Component { | |||
| <img | |||
| className="upsell-certificate" | |||
| src="https://courses.edx.org/static/images/edx-verified-mini-cert.png" | |||
| alt="Sample verified certificate" | |||
| alt="Sample verified statement of accomplishment" | |||
mumarkhan999
force-pushed
the
umar/update-lms-common-openedx-side-certificate-language
branch
from
723abda
to
a816d87
Compare
| @@ -72,13 +72,14 @@ def get_certificate_description(mode, certificate_type, platform_name): | |||
| elif mode == 'verified': | |||
| # Translators: This text describes the 'ID Verified' course certificate type, which is a higher level of | |||
| # verification offered by edX. This type of verification is useful for professional education/certifications | |||
| certificate_type_description = _("A {cert_type} certificate signifies that a " | |||
| # ucsd-customizations: Here I am removing {cert_type} as ucsd is only using verified certificates so we | |||
There was a problem hiding this comment.
Suggested change
| # ucsd-customizations: Here I am removing {cert_type} as ucsd is only using verified certificates so we | |
| # [UCSD_CUSTOM] [EDS-SOMETHING]: Here I am removing {cert_type} as ucsd is only using verified certificates so we |
can we do something like this for consistency?
mumarkhan999
force-pushed
the
umar/update-lms-common-openedx-side-certificate-language
branch
from
a816d87
to
7997486
Compare
HamzaIbnFarooq
approved these changes
Feb 24, 2020
danialmalik
approved these changes
Feb 24, 2020
mumarkhan999
deleted the
umar/update-lms-common-openedx-side-certificate-language
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story Link
https://edlyio.atlassian.net/browse/EDS-245
PR Description
The language of "certificate" has been replaced with "statement of accomplishment"
Type of change
Please select the options that are relevant.
Checklist before merging: