Umar/update user unenroll content #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danialmalik
suggested changes
Feb 14, 2020
lms/static/js/dashboard/legacy.js
Outdated
| diagAttr['data-track-info'] = gettext('Are you sure you want to unenroll from the verified ' + | ||
| '%(certNameLong)s track of %(courseName)s (%(courseNumber)s)?'); | ||
| diagAttr['data-track-info'] = gettext('Are you sure you want to unenroll from the ' + | ||
| 'Statement of Accomplishment track of %(courseName)s (%(courseNumber)s)?'); |
There was a problem hiding this comment.
There is a config CERT_NAME_LONG in common.py. Please check if we can achieve this change using that config instead of hardcoding it here.
There was a problem hiding this comment.
Yeah working on it. but we still have to make some changes in the js file as that file still has the word "verified" which needs to be updated in theme.
|
Your PR has finished running tests. The following contexts failed:
|
1 similar comment
|
Your PR has finished running tests. The following contexts failed:
|
mumarkhan999
force-pushed
the
umar/update-user-unenroll-content
branch
from
c9707d4
to
fd4baef
Compare
HamzaIbnFarooq
approved these changes
Feb 14, 2020
danialmalik
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story Link
https://edlyio.atlassian.net/browse/EDS-104
PR Description
This PR includes the changes related to updating the content of the message shown when the user clicks on
unenrollbutton.Checklist before merging: