Tehreem/remove extra ecommerce domain cookie settings #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasawernawaz
approved these changes
Nov 14, 2019
mumarkhan999
approved these changes
Nov 14, 2019
danialmalik
deleted the
tehreem/remove_extra_ecommerce_domain_cookie_settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link: https://edlyio.atlassian.net/secure/RapidBoard.jspa?rapidView=3&projectKey=EDS&modal=detail&selectedIssue=EDS-99
Description: We were using a new setting variable ECOMMERCE_COOKIE DOMAIN for Authorizenet notification on the LMS side. But our requirement can also be fulfilled with the existing edX setting variable SESSION_COOKIE_DOMAIN.
So we need to remove ECOMMERCE_COOKIE DOMAIN and use SESSION_COOKIE_DOMAIN instead.
Checks before merge: