Refactor if conditions for caliper settings #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumarkhan999
requested review from
tasawernawaz,
imhassantariq and
tehreem-sadat
mumarkhan999
force-pushed
the
umar/apply-if-condition-on-kafka-settings
branch
from
644abd1
to
76e60d5
Compare
tehreem-sadat
approved these changes
Oct 30, 2019
imhassantariq
approved these changes
Oct 30, 2019
mumarkhan999
force-pushed
the
umar/apply-if-condition-on-kafka-settings
branch
from
76e60d5
to
c3be5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings related to
CALIPER_DELIVERYandKAFKA_DELIVERYare moved insideifblocks so that if these settings are not given in the settings fileNONE TYPEerror can be avoided.