-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and test ordering in observable:MessageThread #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-on patch will generate Make-managed files. References: * #393 Signed-off-by: Alex Nelson <[email protected]>
References: * #393 Signed-off-by: Alex Nelson <[email protected]>
11 tasks
No effects were observed on Make-managed files. References: #393 Signed-off-by: Alex Nelson <[email protected]>
No effects were observed on Make-managed files. References: #393 Signed-off-by: Alex Nelson <[email protected]>
A follow-on patch will generate Make-managed files. References: #393 Signed-off-by: Alex Nelson <[email protected]>
References: #393 Signed-off-by: Alex Nelson <[email protected]>
Users interested in representing a message occurring in a thread, without knowing the order of that message, should use the `co:element` property as demonstrated in the updated example `message_thread_PASS.json`. A follow-on patch will regenerate Make-managed files. References: #393 Signed-off-by: Alex Nelson <[email protected]>
References: #393 Signed-off-by: Alex Nelson <[email protected]>
b0bkaT
approved these changes
Jul 22, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request resolves all requirements of Issue 393.
Review steps taken:
message.json
updated in this PR