Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 501: Storage Device Capacity #362

Merged
merged 7 commits into from
Jan 18, 2023
Merged

Issue 501: Storage Device Capacity #362

merged 7 commits into from
Jan 18, 2023

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Mar 28, 2022 •
edited by ajnelson-nist
Loading

  • Create a new facet DeviceStorageFacet in the uco-observable namespace.
  • Add a totalStorageCapacityInBytes property to the newly created DeviceStorageFacet.
  • Remove storageCapacityInBytes property from MobileDeviceFacet and SIMCardFacet

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed.
  • CI passes in UCO feature branch
  • CI passes in UCO current unstable branch (f162e06)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (e11879e)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

@ajnelson-nist ajnelson-nist added this to the UCO 1.x.0 milestone Nov 1, 2022
@b0bkaT
Merge branch 'develop' into CP-88-Storage-Device-Capacity
2084402
@b0bkaT
Updated in accordance with discussion on CP-88/OC-254
db41bd4 
Changed observable:DeviceStorageFacet to observable:StoargeMediumFacet,
and reverted changes that removed observable:storageCapacityInBytes.
ajnelson-nist
ajnelson-nist requested changes Nov 3, 2022
View reviewed changes
ontology/uco/observable/observable.ttl Outdated Show resolved Hide resolved
ontology/uco/observable/observable.ttl Outdated Show resolved Hide resolved
ontology/uco/observable/observable.ttl Outdated Show resolved Hide resolved
ontology/uco/observable/observable.ttl Outdated Show resolved Hide resolved
b0bkaT and others added 2 commits November 3, 2022 16:23
@b0bkaT
Fixed errors in observable.ttl based on feedback on PR 326
c6da182
@ajnelson-nist
Add deprecation annotation, and correct property references
25fd709 
References:
* [OC-49] (CP-88) UCO needs to be able to represent a storage device's
  storage capacity
* https://www.w3.org/TR/2012/REC-owl2-mapping-to-rdf-20121211/
  See Table 16, 4th row from bottom, for deprecation pattern.

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist marked this pull request as draft November 3, 2022 20:50
@ajnelson-nist ajnelson-nist changed the title CP-88 Storage Device Capacity (Issue 501) Storage Device Capacity Nov 8, 2022
@ajnelson-nist ajnelson-nist changed the title (Issue 501) Storage Device Capacity Issue 501: Storage Device Capacity Nov 8, 2022
@ajnelson-nist ajnelson-nist modified the milestones: UCO 1.x.0, UCO 1.2.0 Nov 8, 2022
@ajnelson-nist ajnelson-nist linked an issue Nov 8, 2022 that may be closed by this pull request
UCO needs to be able to represent a storage device's storage capacity #501
Closed
14 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Nov 8, 2022
Closed
14 tasks
@ajnelson-nist ajnelson-nist marked this pull request as ready for review January 18, 2023 03:38
@ajnelson-nist ajnelson-nist merged commit 72427e2 into ucoProject:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnelson-nist ajnelson-nist ajnelson-nist approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.2.0
Development

Successfully merging this pull request may close these issues.

UCO needs to be able to represent a storage device's storage capacity
3 participants
@kchason @ajnelson-nist @b0bkaT