Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opj_free cannot be found #1323

Closed
wants to merge 1 commit into from
Closed

opj_free cannot be found #1323

wants to merge 1 commit into from

Conversation

szukw000
Copy link
Contributor

opj_free() cannot be found in JP3D.Use free() instead.

@rouault
Copy link
Collaborator

rouault commented Jan 10, 2021

Are you (or anyone) actually using JP3D ?

@szukw000
Copy link
Contributor Author

@rouault ,
no, I do not use it now. I only compile it.
A JP3D-testfile would be nice to see where the traps are.
winfried

@rouault
Copy link
Collaborator

rouault commented Jan 10, 2021

We should probably get rid of anything that is not libopenjp2

@rouault
Copy link
Collaborator

rouault commented Jan 12, 2021

@ValZapod are you making real-life use of that part of the code base ?

@rouault
Copy link
Collaborator

rouault commented Jan 12, 2021

Are you trying to say that 3D in by itself is not used anymore?

I'm not talking about 3D in general, but about this JP3D component ! I've the feeling that it is abandoned code and I seriously consider proposing we remove that off from the codebase so people aren't distracted by code that isn't used.

@malaterre
Copy link
Collaborator

@rouault I understand your comment, however there are really two issues here:

  1. Nobody (but me) actually ever used JP3D,
  2. opj 2.4.0 was released with a piece of (mostly) unused code that does not compile (this is an issue for distro maintainer).

I'd suggest you merge #1323 for now, and open a proposal / PR that will remove JP3D for the next major release. thanks for maintaining opj.

cc: @detonin

@malaterre
Copy link
Collaborator

ping @ichlubna

@ichlubna
Copy link
Contributor

ichlubna commented Feb 4, 2021

We have used JP3D in our research

@rouault
Copy link
Collaborator

rouault commented May 6, 2021

PR no longer relevant since #1350

@rouault rouault closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants