Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coverity Scan analysis #580

Closed
mayeut opened this issue Sep 11, 2015 · 11 comments
Closed

Add Coverity Scan analysis #580

mayeut opened this issue Sep 11, 2015 · 11 comments

Comments

@mayeut
Copy link
Collaborator

mayeut commented Sep 11, 2015

GitHub, travis-ci & Coverity Scan work well together.
OpenJPEG should make full use of this by adding Coverity Scan analysis to find defect as soon as possible.

@detonin
Copy link
Contributor

detonin commented Sep 12, 2015

coverity just fixed sth that prevented settings to be updated to link to the new github repo. Integration with github and travis should work now.

@detonin
Copy link
Contributor

detonin commented Sep 12, 2015

Btw, they recommend to create a coverity branch where we merge when we want to trigger a scan, rather than triggering a scan for each and every commit.
https://scan.coverity.com/travis_ci

@mayeut
Copy link
Collaborator Author

mayeut commented Sep 12, 2015

@detonin,

It seems that the link between coverity & GitHub is not done.
Project Settings in Coverity shows that a link should be done.
I can't do this as I have no Admin access to the repo (I guess, the error is cryptic when I click submit). Could you do that please ?

@detonin
Copy link
Contributor

detonin commented Sep 12, 2015

@mayeut ,
Yes I did it too but nothing seems to happen. I get the following error:
Failed to link project. Name contains invalid characters.

I'll dig into this or contact the support again if i don't solve this myself.

@detonin
Copy link
Contributor

detonin commented Sep 12, 2015

I changed the name in coverity to fix previous issue but now there is no github integration link button anymore. I'll contact the support

@detonin
Copy link
Contributor

detonin commented Sep 14, 2015

waiting for coverity support to answer

@detonin
Copy link
Contributor

detonin commented Sep 16, 2015

No answer from support.
I've re-created a project directly linked with github.
Configuring travis-ci should work now with instructions found in "Configure Travis-CI" tab, on the page reached when clicking "submit a build".

mayeut added a commit that referenced this issue Sep 17, 2015
mayeut added a commit that referenced this issue Sep 17, 2015
mayeut added a commit that referenced this issue Sep 17, 2015
mayeut added a commit that referenced this issue Sep 17, 2015
@mayeut
Copy link
Collaborator Author

mayeut commented Sep 17, 2015

What cmake options shall be enabled ?

  • BUILD_CODEC
  • BUILD_THIRDPARTY

@detonin
Copy link
Contributor

detonin commented Sep 17, 2015

I would recommend these two options only for now.
MJ2, JPIP, and JPWL are (still) obsolete in master and I did not yet take a decision on the future of these features. Comments welcome btw.

@mayeut
Copy link
Collaborator Author

mayeut commented Oct 14, 2015

This is done for some time now.

@mayeut mayeut closed this as completed Oct 14, 2015
@stweil
Copy link
Contributor

stweil commented Aug 14, 2017

@detonin, @mayeut, I suggest updating https://scan.coverity.com/projects/uclouvain-openjpeg. There were a lot of code changes since the last version which is covered by Coverity scan (September 2016).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants