e2_colr/a4_colr/b2_mono/a6_mono_colr is failing the test suite

[gcode-importer]

Originally reported on Google Code with ID 289

e2_colr is failing the test suite as can be seen:

http://my.cdash.org/testDetails.php?test=14097705&build=580755

******Parameters********* 
 base_filename = /home/voxxl/Dashboards/MyTests/data/baseline/conformance/e2_colr.ppm
 test_filename = /home/voxxl/Dashboards/MyTests/openjpeg-continuous-linux_gcc47-trunk-debug/tests/conformance/Temporary/e2_colr.j2c.ppm
 nb of Components = 1
 Non regression test = 0
 separator Base = 
 separator Test = 
 MSE values = [ 1.000000 ]
 PEAK values = [ 4.000000 ]
 Non-regression test = 0
 NbFilename to generate from base filename = 0
 NbFilename to generate from test filename = 0
************************* 
Step 1 -> Header comparison
ERROR: height mismatch [comp 0] (594><149)

Reported by malaterre on 2014-03-13 15:47:04

[gcode-importer]

The baseline is odd-shaped:

$ head -4 data/baseline/conformance/e2_colr.ppm
P3
# Copyright (c) 2000-2003 Pegasus Digital Imaging
1023 594
255

However, the codestream is declared as:

[...]
2       : New marker: SIZ (Image and tile size)

  Required Capabilities          : JPEG2000 full standard
  Reference Grid Size            : 1025x601
  Image Offset                   : 2x7
  Reference Tile Size            : 511x793
  Reference Tile Offset          : 2x7
  Components                     : 3
  Component #0 Depth             : 8
  Component #0 Signed            : no
  Component #0 Sample Separation : 4x4
  Component #1 Depth             : 8
  Component #1 Signed            : no
  Component #1 Sample Separation : 4x4
  Component #2 Depth             : 8
  Component #2 Signed            : no
  Component #2 Sample Separation : 4x4
[...]

Reported by malaterre on 2014-03-13 15:48:27

[gcode-importer]

Reported by malaterre on 2014-03-14 11:29:59

[gcode-importer]

Reported by malaterre on 2014-03-14 11:45:04

[gcode-importer]

This issue was updated by revision r2737.

Reported by malaterre on 2014-03-14 12:12:44

[gcode-importer]

Issue 279 has been merged into this issue.

Reported by malaterre on 2014-03-14 13:04:34

[gcode-importer]

Reported by malaterre on 2014-03-14 14:05:00

• Status changed: Started

[gcode-importer]

Reported by detonin on 2014-03-24 15:57:45

• Labels added: Conformance

[gcode-importer]

Reported by malaterre on 2014-03-25 10:38:06

• Labels added: Priority-Low
• Labels removed: Priority-Medium

[gcode-importer]

@mathieu, @antonin,

an option to compensate for dx/dy in opj_decompress would probably be the best way
to pass these tests.

Any thoughts ?

Reported by mayeut on 2014-11-22 12:54:05

[gcode-importer]

This issue was closed by revision r2942.

Reported by mayeut on 2014-11-22 14:09:24

• Status changed: Fixed

[gcode-importer]

wrong issue number in commit, sorry

Reported by mayeut on 2014-11-22 14:10:32

• Status changed: Started

[gcode-importer]

Reported by mayeut on 2014-11-22 14:29:19

[gcode-importer]

This issue was updated by revision r2943.

Reported by mayeut on 2014-11-22 17:55:51

[gcode-importer]

This issue was updated by revision r2944.


Issue is left open since there's still one image failing the tests.

Reported by mayeut on 2014-11-22 17:59:13

[gcode-importer]

commit r2944 deals with up sampling image components to image size.

"  -upsample\n"
"    Downsampled components will be upsampled to image size\n"

This gives a good example of how image/component offsets to reference grid work in
case of sub-sampling (this was not intuitive for me).

Now that all components are of the same size with all dx/dy == 1, a6_mono_colr is output
as a single ppm image (imagetopnm assumes rgba) so tests are still failing.

Reported by mayeut on 2014-11-22 18:15:31

[gcode-importer]

@mathieu,

I think we can add yet another option to opj_decompress to force component splitting
in imagetopnm.
Any thoughts ?

Reported by mayeut on 2014-12-03 20:28:09

[mayeut]

All images mentioned in this issue are now properly handled and passing tests