restructure deploy contents to support using kustomize #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the COPY args are source... dest, so "COPY go.mod ./ go.sum ./" coppies ./ to ./ which is unintended as for "COPY pkg ./ cmd ./ version ./" the pkg and cmd args are redundant
…vice mesh wihtout this the redis IP is identified as 127.0.0.1
polefishu
reviewed
May 8, 2020
| @@ -272,6 +272,10 @@ func (c *client) SetCustomRedisConfig(ip string, configs map[string]string, auth | |||
| rClient := rediscli.NewClient(options) | |||
| defer rClient.Close() | |||
|
|
|||
| if err := c.applyRedisConfig("replica-announce-ip", ip, rClient); err != nil { | |||
There was a problem hiding this comment.
There is no replica-announce-ip configuration in redis 3.2.2, I hope the operator supports redis 3.2.2+.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made changes to the contents of /deploy so that you can build a config using kustomize
An example to build a cluster scoped operator
kustomize build deploy/clusterI also changed the image from
REPLACE_IMAGEtoredis-operatorso that you can more easily use kustomize's image replacementfor example in your own project you can use the following to integrate redis-operator into your own kustomization.yaml