Create pageController #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanmsmith
requested changes
Mar 2, 2018
src/controllers/pageController.ts
Outdated
| /** | ||
| * Creates a page with the given attribues | ||
| * | ||
| * @param attributes |
There was a problem hiding this comment.
Add types to your JSDoc comments!
|
Looks good once you add some tests, too @anmol678! See @tanzeelak's PR (#27) for reference. |
nathanmsmith
requested changes
Apr 7, 2018
src/controllers/pageController.ts
Outdated
| @@ -62,7 +67,7 @@ export function updatePage(id: number, attributes: PageLinkAttributes): Promise< | |||
| /** | |||
| * Deletes a page. Returns true if the page was successfully deleted, false otherwise. | |||
| * | |||
| * @param id | |||
| * @param {numebr} id | |||
| /** | ||
| * Creates a page with the given attribues | ||
| * | ||
| * @param {PageLinkAttributes} attributes |
|
Also it looks like some of your tests are failing! Could you see what's happening there @anmol678? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Page controller based on showController.ts
#22