Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process PullRequestReviewCommentEvent properly #10

Closed
mattxwang opened this issue Oct 10, 2021 · 5 comments · Fixed by #13
Closed

Process PullRequestReviewCommentEvent properly #10

mattxwang opened this issue Oct 10, 2021 · 5 comments · Fixed by #13
Labels

Comments

@mattxwang
Copy link
Member

mattxwang commented Oct 10, 2021

The PullRequestReviewCommentEvent occurs frequently enough that it would be nice to have a "translated" version of it on the live feed.

To resolve this, you'll need to:

  1. Inspect the structure of a PullRequestReviewCommentEvent; see the Activity API for GitHub's REST API and the REST Endpoint that we hit
  2. Add a case statement for PullRequestReviewCommentEvent in GitHubEventAction.tsx
  3. Process the relevant parameters for the statement that we'd like to generate. I would like to see something like:
@mattxwang commented on pull request #309 in uclaacm/website

Where the author, pull request, and repository are linked.

The relevant file is here:

function GitHubEventAction({type, payload}: GitHubEventActionProps): JSX.Element {

@devtayls
Copy link
Contributor

I'd like to work on this!

@mattxwang
Copy link
Member Author

I'd like to work on this!

Hi @devtayls, go for it - feel free to open a PR and ask for any help if needed!

@devtayls
Copy link
Contributor

@devtayls
Copy link
Contributor

@mattxwang PR up. Unfortunately, the linter made me change the quotes in the file in order to commit. I'm guessing that the file hadn't been updated since the linter was introduced. 🤷

@mattxwang
Copy link
Member Author

@mattxwang PR up. Unfortunately, the linter made me change the quotes in the file in order to commit. I'm guessing that the file hadn't been updated since the linter was introduced. 🤷

Sorry, I might be missing something - which quotes changes? I see everything as still single-quoted. Do you mean the spacing?

@mattxwang mattxwang linked a pull request Oct 17, 2021 that will close this issue
mattxwang pushed a commit that referenced this issue Oct 17, 2021
Resolves issue #10 

Adds `PullRequestReviewComment` to the list of events in `GithubEventAction.tsx`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants