Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Node to version 18. #2098

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x]
node-version: [18.x]
steps:
- name: Checkout code
uses: actions/checkout@v2
Expand All @@ -19,10 +19,10 @@ jobs:
# should help to speed up yarn install and be safe
# across changes to the repo and platforms
- name: Cache Yarn Deps
uses: c-hive/gha-yarn-cache@v1
uses: c-hive/gha-yarn-cache@v1

- run: echo "github.ref = ${{ github.ref }}"

# frozen lockfile should make the cache more effective
# and our tests more predictable
- run: yarn install --frozen-lockfile
Expand All @@ -35,7 +35,7 @@ jobs:
# will fail the PRs that need prettier run on them
- name: Does Prettier Need to Be Run
run: git --no-pager diff --exit-code -- .

- run: yarn test:ci

build_docker_images:
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- name: NPM - Test, Build, Deploy
uses: actions/setup-node@v1
with:
node-version: 14
node-version: 18
registry-url: https://registry.npmjs.org/

- name: Cache Yarn Deps
Expand Down
2 changes: 1 addition & 1 deletion docker/dockerfiles/obojobo-node-debian.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# =====================================================================================================
# Base stage used for build and final stages
# =====================================================================================================
FROM node:14.16.0-alpine AS base_stage
FROM node:18.16.0-alpine AS base_stage

# ======== PUT NEW NODE BIN DIR IN PATH
RUN npm config set prefix '/home/node/.npm-global'
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,6 @@
],
"engines": {
"yarn": "^1.15.2",
"node": "^14.16.0"
"node": "^18.16.0"
}
}
2 changes: 1 addition & 1 deletion packages/app/obojobo-document-engine/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"license": "AGPL-3.0-only",
"description": "",
"engines": {
"node": "^14.16.0"
"node": "^18.16.0"
},
"main": "index.js",
"scripts": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ describe('api visits route', () => {
expect(response.body.value).toHaveProperty('type', 'reject')
expect(response.body.value).toHaveProperty(
'message',
"Cannot read property 'lis_outcome_service_url' of undefined"
"Cannot read properties of undefined (reading 'lis_outcome_service_url')"
)
})
})
Expand Down
2 changes: 1 addition & 1 deletion packages/app/obojobo-express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"precommit": "lint-staged"
},
"engines": {
"node": "^14.16.0"
"node": "^18.16.0"
},
"lint-staged": {
"**/*.scss": [
Expand Down
2 changes: 1 addition & 1 deletion packages/app/obojobo-module-selector/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"precommit": "lint-staged"
},
"engines": {
"node": "^14.16.0"
"node": "^18.16.0"
},
"lint-staged": {
"**/*.scss": [
Expand Down
2 changes: 1 addition & 1 deletion packages/app/obojobo-repository/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"precommit": "lint-staged"
},
"engines": {
"node": "^14.16.0"
"node": "^18.16.0"
},
"lint-staged": {
"**/*.scss": [
Expand Down
Loading