Reset element IDs in copied modules. #2082
Conversation
…pattern are replaced with new UUIDs. References to the old node IDs in button actions etc. are also replaced with the corresponding new IDs.
There was a problem hiding this comment.
I don't know enough about the existing code to know if this is a problem or not. But in addition to ids that were changed, in the parent object, this also changes the 'rev', 'draftId', and 'contentId'. Do these reference other objects that need to be saved to the database, or does Draft.createWithContent cover that? The front end seemed to work fine when loading and editing both the original and the copy.
| // globally replace each old ID with the equivalent new ID | ||
| // this should replace node IDs as well as action trigger references to those node IDs | ||
| for (const [oldId, newId] of Object.entries(idsForChange)) { | ||
| // this works, but there may be a more efficient way of doing it |
There was a problem hiding this comment.
This is a very elegant solution... Changing keys while retaining values is a pain, while string replacing is simple and relatively fast. The only real concern is making sure you're replacing globally instead of the first instance only, which you've done below AND made sure was included in your test case.
|
A copied module is a new module, so |
FrenjaminBanklin
changed the base branch from
dev/31-taconite
to
dev/32-pigeonite
|
This was previously reviewed and everything still appears to be working correctly after modernizing from the current dev branch. I'm going to go ahead and call it good. |
Closes #2081.
When making a copy of a module, all element IDs following the UUID format will be replaced. References to the old IDs in button actions etc. will also be updated with the corresponding new ID.