Update numeric question validity checks #2027
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2012
The initial issue was that the editor allows saving when a margin of error question is created with an answer of 0 and an error type of 'Percent', which would cause a blank screen error when viewing the assessment. This also occurs if any other input for numeric questions is invalid (range invalid, answer can't be parsed to a number, etc.). The first part of these changes adds a validity check to make sure that a margin of error question doesn't have an answer of 0 with an error type of 'Percent'. The other part adds a check before saving that checks the validity of all
input
andselect
fields. If any are invalid, the module won't be saved and an alert will be shown, so this will prevent any type of invalid input from being saved.