Accessibility Fixes for Assessment Updates #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deundrewilliams
changed the base branch from
dev/26-neon-apatite
to
dev/27-pyrite
deundrewilliams
force-pushed
the
issue/1788-assessment-accessibility
branch
from
110d67b to
9f2b29a
Compare
FrenjaminBanklin
previously approved these changes
Jan 28, 2022
There was a problem hiding this comment.
Checked this with Chromevox. It looks like it addresses the shortcomings mentioned in the ticket - the screen reader indicates when an answer is saved and when a submission has finished. Well done!
I did notice while testing this that using the keyboard to navigate multiple choice questions with only a single correct answer is extremely difficult, but since that also appears to be happening on the current dev branch I'm going to say it isn't due to your changes. I'll open a separate issue.
FrenjaminBanklin
requested review from
a team,
zachberry and
sergioncp
and removed request for
a team
deundrewilliams
dismissed
FrenjaminBanklin’s stale review
The base branch was changed.
FrenjaminBanklin
changed the base branch from
dev/28-jadeite
to
dev/29-sodalite
FrenjaminBanklin
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1788
aria-liveto the modal component so the screenreader will read any text updates inside, this affects the response dialog after submitting an assessmentaria-livetoQuestionResponseStatusto keep track of statuses already read + avoid repeating announcements. Whenever a new status is received, text inside a hidden div is updated and read by the screenreader