Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes strange rubric rendering with set passing score #1866

Conversation

jpeterson976
Copy link
Contributor

Fixes #1863

It didn't seem to like when the attempt score was 100 but the rubric sets the score to >100 when passing, so I added a new display type for that case that gives the same info as when the attempt score is less than 100 but passes.

@jpeterson976 jpeterson976 requested review from a team, zachberry and iturgeon and removed request for a team June 22, 2021 19:28
@zachberry zachberry added this to the 24 - TBA milestone Jun 24, 2021
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a simpler way to tackle this - I'm thinking we merge these:

TYPE_PASSFAIL_PASSED_GIVEN_SCORE_AND_ATTEMPT_SCORE_LESS_THAN_100,
TYPE_PASSFAIL_PASSED_GIVEN_SCORE_AND_ATTEMPT_SCORE_IS_100_AND_NO_MODS_REWARDED,
TYPE_PASSFAIL_PASSED_GIVEN_SCORE_AND_ATTEMPT_SCORE_IS_100_AND_MODS_REWARDED,

Into just one: TYPE_PASSFAIL_PASSED_GIVEN_SCORE

And it would replace the case in the switch for TYPE_PASSFAIL_PASSED_GIVEN_SCORE_AND_ATTEMPT_SCORE_LESS_THAN_100.

That way any time a score is strictly set for meeting the threshold score it would always render as

Attempt Score (Passed): xx%
--------
Score adjusted for passing: yy%

I think the code as it is is attempting to avoid situations where the set score is equal to the attempt score (So students don't see text like Score: 100%, Score adjusted for passing: 100%), but with the ability of hindsight I think that was probably a bad decision. If we don't care about it, it will simplify the code and remove this problem

@zachberry zachberry modified the milestones: 24 - Sunstone, 25 - Bixbite Jul 26, 2021
@zachberry zachberry changed the base branch from dev/23-rose-quartz to dev/25-bixbite August 18, 2021 21:43
Copy link
Member

@zachberry zachberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all the combination of rubrics I could think of, all working great. I merged in the latest dev/25 changes and assuming the tests past I'll merge in

@zachberry zachberry merged commit b26e82b into ucfopen:dev/25-bixbite Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants