Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node to version 18. #2013

Closed
FrenjaminBanklin opened this issue Jun 28, 2022 · 2 comments · Fixed by #2102
Closed

Upgrade Node to version 18. #2013

FrenjaminBanklin opened this issue Jun 28, 2022 · 2 comments · Fixed by #2102
Assignees
@FrenjaminBanklin
Labels
chore Maintain a clean and strong character. upgrade change versions of something

Comments

@FrenjaminBanklin
Copy link
Contributor

FrenjaminBanklin commented Jun 28, 2022 •
edited
Loading

Obojobo is currently using version 14 of Node, which falls out of long-term support in the first half of 2023.

Ideally we should move all the way up to version 18, but at the very least we'll need to be running on version 16 before LTS ends for version 14.
@FrenjaminBanklin FrenjaminBanklin added upgrade change versions of something chore Maintain a clean and strong character. labels Jun 28, 2022
@FrenjaminBanklin
Copy link
Contributor Author

Targeting 16 for now. Would prefer to go straight to 18, but the trianglify library has a dependency, canvas, which does not have a pre-built downloadable in Node 18 at the currently locked version. Theoretically the build -can- work in Node 18 provided a number of OS packages are installed, but I'd like to avoid it if at all possible.

Coast with Node 16 for now but make a new issue to move to 18 before 16's security support drops off in September.

@FrenjaminBanklin FrenjaminBanklin changed the title Upgrade Node version. Upgrade Node to version 16. Jan 9, 2023
FrenjaminBanklin added a commit to FrenjaminBanklin/Obojobo that referenced this issue Jan 9, 2023
@FrenjaminBanklin
ucfopen#2013 Bumped Node engine version to 16.19.0. Adjusted Dockerfi…
93948f3 
…le base image accordingly. Changed test expectations for 'property of undefined' error message.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Jan 9, 2023
Closed
FrenjaminBanklin added a commit to FrenjaminBanklin/Obojobo that referenced this issue Jan 9, 2023
@FrenjaminBanklin
ucfopen#2013 Changing Github workflows to run tests etc. using Node 1…
43edfef 
…6 instead of 14.
FrenjaminBanklin added a commit to FrenjaminBanklin/Obojobo that referenced this issue Jan 9, 2023
@FrenjaminBanklin
ucfopen#2013 Trying a more specific version of Node for GH automated …
f3b64e7 
…tests.
@FrenjaminBanklin FrenjaminBanklin self-assigned this Jan 10, 2023
@FrenjaminBanklin
Copy link
Contributor Author

It looks like throwing away the existing lockfile and allowing it to rebuild from scratch resolves the issues I was running into re: trianglify and node-canvas. I'll have to sanity check the new lockfile to make sure everything still works properly, but that may allow us to go straight to Node 18 after all.

FrenjaminBanklin added a commit to FrenjaminBanklin/Obojobo that referenced this issue Jun 27, 2023
@FrenjaminBanklin
ucfopen#2013 Made minimal changes to locked package versions to suppo…
ce9fb77 
…rt Node 18. Updated Node version requirements in relevant package.json files, fixed new undefined error message in tests.
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Jun 27, 2023
Merged
@FrenjaminBanklin FrenjaminBanklin changed the title Upgrade Node to version 16. Upgrade Node to version 18. Aug 21, 2023
@FrenjaminBanklin FrenjaminBanklin mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrenjaminBanklin FrenjaminBanklin

Labels
chore Maintain a clean and strong character. upgrade change versions of something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev/32 - Pigeonite ucfopen/Obojobo
1 participant
@FrenjaminBanklin